refactor: Modernize code with rector - #1482
Merged
Merged
Conversation
CarlSchwan
force-pushed
the
carl/rector
branch
from
February 6, 2026 15:51
fa984a1 to
470858f
Compare
CarlSchwan
force-pushed
the
carl/rector
branch
6 times, most recently
from
February 6, 2026 16:45
fae97f1 to
7a3869d
Compare
provokateurin
requested changes
Feb 9, 2026
CarlSchwan
force-pushed
the
carl/rector
branch
from
February 9, 2026 11:34
88cb5e4 to
84a5a3a
Compare
provokateurin
approved these changes
Feb 9, 2026
CarlSchwan
force-pushed
the
carl/rector
branch
from
February 10, 2026 12:00
84a5a3a to
df3a290
Compare
Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/rector
branch
from
February 10, 2026 12:53
df3a290 to
485fa1d
Compare
CarlSchwan
enabled auto-merge
February 10, 2026 12:53
| public function __construct($cache, $mask, callable $checkPath) { | ||
| public function __construct( | ||
| ICache $cache, | ||
| int $mask, |
Member
There was a problem hiding this comment.
Message: OCA\Guests\Storage\DirMaskCache::__construct(): Argument #2 ($mask) must be of type int, null given, called in /var/www/html/apps/guests/lib/Storage/DirMask.php on line 190 in file '/var/www/html/apps/guests/lib/Storage/DirMaskCache.php' line 21
File: /var/www/html/lib/private/AppFramework/Http/Dispatcher.php
Line: 107
| */ | ||
| private $pathLength; | ||
|
|
||
| private $mask; |
Member
There was a problem hiding this comment.
Removal of this is now trying to use PermissionsMask::$mask in getCache() but that is private instead of protected, so you can not use it, so it's null but the DirMaskCache is typed for int
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.