fix: add null check to guest to allow the repair step to continue - #1425
fix: add null check to guest to allow the repair step to continue#1425yemkareems wants to merge 1 commit into
Conversation
Signed-off-by: yemkareems <yemkareems@gmail.com>
|
@kesselb your link is just the link to this PR? |
| if ($guest === null) { | ||
| continue; |
There was a problem hiding this comment.
Should the guest get deleted as well, if this case is detected? I don't know anything about this app, but find it a bit strange that there can be a guest without a user. I assume this happens when the user is deleted? Please provide a little more insight here.
There was a problem hiding this comment.
We are asking the guests manager for a list of guests and then obtaining the user object from the user backend. The guests app itself implements a user backend, and thus it's indeed weird that we cannot find the user again that was just returned by the other call. The change here ensures that the repair step runs through and does not brick the update.
|
Thanks @provokateurin for the heads-up, I'v indeed mixed up the links ;) It's #1424. |
|
Yeah let's go with that PR as it also includes logging for this weird issue. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
3 participants
In few cases when guest is null this breaks the repair step and occ upgrade fails.