fix: don't allow empty email even if email change is allowed - #1410
Merged
Conversation
Signed-off-by: Robin Appelman <robin@icewind.nl>
AndyScherzinger
approved these changes
Sep 15, 2025
provokateurin
approved these changes
Sep 15, 2025
come-nc
reviewed
Sep 15, 2025
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
email-change-tweaks
branch
from
September 17, 2025 16:12
a420277 to
b901548
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the email change is allowed (such as when an admin changes it), save a copy of it so when we need to prevent a change, we can set it back to the last value instead of resetting it to the uid.