Load scripts if a user is logged in and is allowed invite guests - #1402
Merged
Conversation
leftybournes
force-pushed
the
leftybournes/fix/guest_dialog
branch
3 times, most recently
from
September 4, 2025 05:44
1c030b0 to
482764a
Compare
Signed-off-by: Kent Delante <kent.delante@proton.me>
leftybournes
force-pushed
the
leftybournes/fix/guest_dialog
branch
from
September 4, 2025 05:50
482764a to
d0ecda1
Compare
Scripts would load everywhere, including on the login screen when it isn't necessary. Load the guest scripts if logged in and able to invite guests. Signed-off-by: Kent Delante <kent.delante@proton.me>
leftybournes
force-pushed
the
leftybournes/fix/guest_dialog
branch
from
September 4, 2025 08:01
d0ecda1 to
9310d30
Compare
Signed-off-by: Kent Delante <kent.delante@proton.me>
leftybournes
force-pushed
the
leftybournes/fix/guest_dialog
branch
from
September 4, 2025 08:06
9310d30 to
4191bac
Compare
nickvergessen
approved these changes
Sep 4, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scripts are loaded on the login page, which is unnecessary. This fixes the issue by only loading the scripts to add guests if a user is logged in and has the ability to invite guests.