feat: add better description in settings - #1390
Merged
Merged
Conversation
skjnldsv
requested review from
sorbaugh and
susnux
and removed request for
a team
August 28, 2025 06:40
skjnldsv
added
enhancement
artonge
approved these changes
Aug 28, 2025
susnux
approved these changes
Aug 28, 2025
szaimen
reviewed
Aug 28, 2025
Comment on lines
+12
to
+13
| {{ t('guests', 'They don\'t get their own storage, but can log in and work together on files, folders and chats you share with them.') }} | ||
| {{ t('guests', 'Guests are always identified as such, to make it clear who\'s part of your team and who\'s an external collaborator.') }} |
There was a problem hiding this comment.
Nitpick: I am not sure if we should eventually start using the correct apostrophe characters:
Suggested change
| {{ t('guests', 'They don\'t get their own storage, but can log in and work together on files, folders and chats you share with them.') }} | |
| {{ t('guests', 'Guests are always identified as such, to make it clear who\'s part of your team and who\'s an external collaborator.') }} | |
| {{ t('guests', 'They don’t get their own storage, but they can log in and work together on files, folders and chats you share with them.') }} | |
| {{ t('guests', 'Guests are always identified as such, to make it clear who’s part of your team and who’s an external collaborator.') }} |
Cc @nextcloud/designers
Contributor
There was a problem hiding this comment.
No - or if yes then clarify this first with our translators (@rakekniven ) but the current guides state the opposite:
https://docs.nextcloud.com/server/latest/developer_manual/basics/translations.html#dos-and-don-ts
Meaning no abbrev at all - always write the full words like do not instead of don't
Member
There was a problem hiding this comment.
We definitely should — but indeed, in the future, as a coordinated effort.
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
feat/better-desc
branch
from
August 28, 2025 07:31
0f12198 to
2c0b71a
Compare
skjnldsv
enabled auto-merge
August 28, 2025 07:31
skjnldsv
added
4. to release
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #1315
