fix: remove constructor overwrite from AppConfigOverwrite - #1367
Merged
Conversation
icewind1991
force-pushed
the
config-overwrite-constructor
branch
from
August 4, 2025 11:39
40234e8 to
b85b1af
Compare
kesselb
approved these changes
Aug 4, 2025
ArtificialOwl
approved these changes
Aug 4, 2025
icewind1991
force-pushed
the
config-overwrite-constructor
branch
from
August 5, 2025 11:53
b85b1af to
28e0a8f
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
config-overwrite-constructor
branch
from
August 5, 2025 11:56
28e0a8f to
301289c
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the need to keep it in sync with the parent constructor