Conversation
…llelization ubuntu-latest jobs get picked up by both GitHub-hosted and self-hosted runners, which can run different Ubuntu point releases. Cypress Cloud refuses to parallelize a run whose machines report different OS versions, so those runners exit before running a single spec. Let cypress-split, already set up in cypress.config.ts, hand each runner its share of the specs instead. Also read the Nextcloud logs from the container name that @nextcloud/e2e-test-server actually uses, so they get uploaded when a run fails. Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ubuntu-latestjobs here land on both GitHub-hosted runners and the self-hostedgarm-*runners, and those currently run different Ubuntu point releases (24.04.5 vs 24.04.4). Cypress Cloud refuses to parallelize a run whose machines report different OS versions (parallel-group-params-mismatch), so the mismatched runners stop before running any spec and the job fails with "Could not find Cypress test run results". See runners 1 and 3 in https://github.com/nextcloud/groupfolders/actions/runs/34579398382.cypress.config.tsalready registerscypress-split, so each runner now picks its share of the specs fromSPLIT/SPLIT_INDEX, the same way deck and text do. The trade-off is that runs are no longer recorded to Cypress Cloud (no dashboard or Test Replay).The "Extract NC logs" step also looked for
nextcloud-cypress-tests_groupfolders, but@nextcloud/e2e-test-server0.4.0 names the containernextcloud-e2e-test-server_groupfolders, so logs were never uploaded on failure.Unrelated to this change: "Correctly moves versions when user moves the containing folder out of the groupfolder" is currently flaky on master and stable34 as well.