Skip to content

fix(workflow): adjust branches on sync-workflow-templates.yml - #216

Merged
cristianscheid merged 1 commit into
masterfrom
fix/noid/adjust-sync-workflow-templates
Jun 30, 2026
Merged

fix(workflow): adjust branches on sync-workflow-templates.yml#216
cristianscheid merged 1 commit into
masterfrom
fix/noid/adjust-sync-workflow-templates

Conversation

@cristianscheid

@cristianscheid cristianscheid commented Jun 30, 2026

Copy link
Copy Markdown
Member

Summary

Branches listed on sync-workflow-templates.yml do not match actual branches of this repo:

jobs:
  dispatch:
    runs-on: ubuntu-latest

    strategy:
      fail-fast: false
      matrix:
        branches:
          - ${{ github.event.repository.default_branch }}
          - 'stable34' # does not exist on this repo
          - 'stable33' # does not exist on this repo
          - 'stable32' # does not exist on this repo

This PR adds a patch to change for branches section to use branches corresponding to the currently supported versions of NC.

Steps done to add a patch to sync-workflow-templates.yml:

# make changes needed on sync-workflow-templates.yml

# create patch file
git diff .github/workflows/sync-workflow-templates.yml > .github/workflows/sync-workflow-templates.yml.patch

# check patch is in good shape
patch -p1 --dry-run < .github/workflows/sync-workflow-templates.yml.patch

# commit both the patch and workflow with changes

# add patch reference on REUSE.toml

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@cristianscheid

Copy link
Copy Markdown
Member Author

psalm error is unrelated, and after merging this one, the updater should run successfully and fix the psalm error as well

@artonge artonge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add a .patch file in the same directory so that the workflow can be automatically updated without losing those changes

@cristianscheid
cristianscheid force-pushed the fix/noid/adjust-sync-workflow-templates branch from e9cd91b to bb9d9ca Compare June 30, 2026 14:12

@artonge artonge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to include the changes in the yml file ;)

@cristianscheid
cristianscheid force-pushed the fix/noid/adjust-sync-workflow-templates branch from bb9d9ca to 8938064 Compare June 30, 2026 14:23
Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
@cristianscheid
cristianscheid force-pushed the fix/noid/adjust-sync-workflow-templates branch from 8938064 to a91c1a9 Compare June 30, 2026 14:26
@cristianscheid
cristianscheid requested a review from artonge June 30, 2026 14:55
@cristianscheid
cristianscheid merged commit 3248cc5 into master Jun 30, 2026
37 of 38 checks passed
@cristianscheid
cristianscheid deleted the fix/noid/adjust-sync-workflow-templates branch June 30, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants