Fix: Remove disabled users from the lookup server - #213
Conversation
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com> Assisted-by: Claude Code:Opus 4.8
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
artonge
left a comment
There was a problem hiding this comment.
Might be similar to #215
cc @cristianscheid
Yes, looking at the changes it accomplishes the same thing as #215. Major difference is how PRs handle existing disabled users on lookup server:
|
|
Following up on this topic, I've updated #215 to include the changes proposed by this PR for the Changes on #215 were included on this commit. I think this makes sense because only removing disabled users at login time would leave their records on the lookup server until they actually attempt to log in. Including this change means the cron job will eventaually clean up any leftover disabled users. @rikled thanks for the contribution, really appreciated! Since now both PRs are more in sync, I'll close this one in favor of the previously open. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Deactivated accounts were never removed from the lookup server: batchUpdate() re-pushed them on every cron run and nothing reacted to disable events, so disabled users kept showing up in federated share contacts.
This change:
🤖 AI (if applicable)
Assisted-by: Claude Code:Opus 4.8