Skip to content

fix: preserve method and URI when redirecting WebDAV through GSS - #196

Merged
ArtificialOwl merged 2 commits into
nextcloud:masterfrom
n-iv:fix/webdav-redirect-preserve-method
Jul 17, 2026
Merged

fix: preserve method and URI when redirecting WebDAV through GSS#196
ArtificialOwl merged 2 commits into
nextcloud:masterfrom
n-iv:fix/webdav-redirect-preserve-method

Conversation

@n-iv

@n-iv n-iv commented May 7, 2026

Copy link
Copy Markdown
Contributor

When Basic credentials are presented on a direct WebDAV endpoint, the master now forwards the request as-is to the slave with a 307, which preserves both method and URI per RFC 9110 §15.4.8. The autologin JWT flow is kept intact for every other path.

Copilot AI review requested due to automatic review settings May 7, 2026 12:46

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@ArtificialOwl

ArtificialOwl commented May 13, 2026

Copy link
Copy Markdown
Member

Why making a request to master and not directly on the slave ?
The address of the correct slave should be provided during the login flow v2 on the poll request.

@n-iv

n-iv commented May 18, 2026

Copy link
Copy Markdown
Contributor Author

Hi @ArtificialOwl

I added a little script so you can check wether it works or not when on a gs scale architecture, with or without the different patches we have put, including the last one.

webdav-nuage.sh

Please feel free to contact me if you want to check it together.

Kind regards

n-iv and others added 2 commits July 17, 2026 14:36
When Basic credentials are presented on a direct WebDAV endpoint,
the master now forwards the request as-is to the slave with a 307,
which preserves both method and URI per RFC 9110 §15.4.8. The
autologin JWT flow is kept intact for every other path.

Signed-off-by: Nicolas Varlot <nicolas.varlot@ac-versailles.fr>


Signed-off-by: Nicolas Varlot <165952530+n-iv@users.noreply.github.com>
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@n-iv
n-iv force-pushed the fix/webdav-redirect-preserve-method branch from 685a4f8 to 7f5bd61 Compare July 17, 2026 12:36
@ArtificialOwl
ArtificialOwl merged commit be994fb into nextcloud:master Jul 17, 2026
2 checks passed
@ArtificialOwl

Copy link
Copy Markdown
Member

/backport to stable2.7

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants