fix: Validate JWT key length for HS256 compatibility - #188
Merged
Conversation
CarlSchwan
approved these changes
Jul 6, 2026
CarlSchwan
force-pushed
the
fix/gss-jwt-key-length-error
branch
from
July 6, 2026 12:03
5664e7b to
0a556ad
Compare
The HS256 algorithm requires a minimum key of 32 bytes per RFC 7518. firebase/php-jwt v7 (used by user_oidc) enforces this, while v6 (used by GSS) does not, causing silent JWT decode failures during OIDC logout delegation from slave to master. Added key length validation with clear error logging in both Master and Slave, and updated README to document the requirement. Signed-off-by: nfebe <fenn25.fn@gmail.com>
CarlSchwan
force-pushed
the
fix/gss-jwt-key-length-error
branch
from
July 6, 2026 12:11
0a556ad to
2cc2ea8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HS256 algorithm requires a minimum key of 32 bytes per RFC 7518. firebase/php-jwt v7 (used by user_oidc) enforces this, while v6 (used by GSS) does not, causing silent JWT decode failures during OIDC logout delegation from slave to master.
Added key length validation with clear error logging in both Master and Slave, and updated README to document the requirement.