[stable32] fix(dev): fix high-severity prose and code errors in developer manual - #14694
Merged
Conversation
AI-Assisted-By: claude-sonnet-4-6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com>
AI-Assisted-By: claude-sonnet-4-6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com>
AngularJS reached end-of-life in December 2021. Nextcloud uses Vue.js. AI-Assisted-By: claude-sonnet-4-6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com>
Code block was labelled "javascript" but contains PHP syntax. AI-Assisted-By: claude-sonnet-4-6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com>
PHP constructors are __construct(), not __constructor(). AI-Assisted-By: claude-sonnet-4-6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com>
AI-Assisted-By: claude-sonnet-4-6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com>
registerService() used AuthorMappers::class (plural) but the class is AuthorMapper::class. AI-Assisted-By: claude-sonnet-4-6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com>
AI-Assisted-By: claude-sonnet-4-6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com>
Event was described as triggered when a user "deletes" a subscription, but the event name and its sibling SubscriptionDeletedEvent make clear it fires on updates. AI-Assisted-By: claude-sonnet-4-6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com>
Correct spelling is NoCSRFRequired (CSRF, not CRSF). AI-Assisted-By: claude-sonnet-4-6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com>
…xamples
fix(dev): fix missing closing parenthesis in reference.rst template examples
{{ t('myapp', 'Title' }} and {{ t('myapp', 'Extra info' }} were both
missing the closing ) before }}.
AI-Assisted-By: claude-sonnet-4-6 <noreply@anthropic.com>
Signed-off-by: Anna Larch <anna@nextcloud.com>
[skip ci]
Member
|
@copilot fix this partial backport based on the original PR. |
skjnldsv
marked this pull request as ready for review
May 1, 2026 14:51
- Resolve conflict in dependency_injection.rst: accept stable32's major rewrite which already has the correct AuthorMapper::class references and also fixes new AuthorService -> AuthorMapper constructor bug - Accept backgroundjobs.rst auto-merge: incorporates stable32's fix for 'time minimum time' redundancy while keeping our semicolon fix - Also fix missing semicolon in new backgroundjobs.rst Scheduling section added by stable32 (same PHP property declaration bug) Signed-off-by: Anna Larch <anna@nextcloud.com> Co-authored-by: skjnldsv <14975046+skjnldsv@users.noreply.github.com>
Contributor
Done in commit Here's what was completed: Merge with stable32 ( Extra fix surfaced by merge: The new Scheduling code example added to Changes not applicable to stable32: Two commits remain intentionally empty ( All 8 applicable fixes from #14619 are present in the final diff vs |
skjnldsv
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #14619
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.