fix(accessmanager): only handle manual redirects unless specified otherwise - #9350
Merged
Conversation
…erwise Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
nilsding
requested review from
Aiiaiiio,
camilasan,
i2h3 and
mgallien
as code owners
January 21, 2026 10:46
Member
Author
|
/backport to stable-4.0 |
mgallien
requested changes
Jan 21, 2026
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-9350.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
mgallien
approved these changes
Jan 21, 2026
|
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also added a test to ensure
NSISUpdaterfollows the redirect from a request. QHttpServer allows for testing scenarios like like these really easy.Resolves #9347