Removed user option for trash deletion - #9322
Merged
Merged
Conversation
i2h3
commented
Jan 16, 2026
i2h3
commented
Collaborator
- Removed XPC APIs for trash state management.
- Removed UserDefaults code about trash state management.
- Removed checkbox from file provider settings tab.
- Removed "Allow deletion of items in Trash" from English translations.
i2h3
requested review from
Aiiaiiio,
camilasan,
mgallien and
nilsding
as code owners
January 16, 2026 07:28
i2h3
added
3. to review
feature: 馃搧 file provider
github-project-automation
Bot
moved this to 馃Л Planning evaluation (don't pick)
in 馃捇 Desktop Clients team
Rello
approved these changes
Jan 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request removes the user-configurable option to allow/disallow deletion of items in the Trash from the macOS File Provider extension. The change simplifies the application by removing a feature that allowed users to control whether trash items could be deleted.
Changes:
- Removed XPC communication APIs for trash deletion state management
- Removed UserDefaults storage and retrieval code for trash deletion settings
- Removed UI checkbox from the File Provider settings interface
- Removed English translation entry and marked the key as obsolete to prevent future collisions
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| translations/client_en.ts | Removed translation entry for "Allow deletion of items in Trash" |
| src/gui/macOS/ui/FileProviderSettings.qml | Removed checkbox UI element for trash deletion control |
| src/gui/macOS/fileproviderxpc_mac.mm | Removed XPC methods to query and set trash deletion state |
| src/gui/macOS/fileproviderxpc.h | Removed trash deletion method declarations from XPC interface |
| src/gui/macOS/fileprovidersettingscontroller_mac.mm | Removed controller methods for trash deletion state management |
| src/gui/macOS/fileprovidersettingscontroller.h | Removed public API methods and signals for trash deletion |
| shell_integration/MacOSX/NextcloudIntegration/FileProviderExt/Services/ClientCommunicationService.swift | Removed XPC service methods for trash deletion |
| shell_integration/MacOSX/NextcloudIntegration/FileProviderExt/Services/ClientCommunicationProtocol.h | Removed protocol methods for trash deletion |
| shell_integration/MacOSX/NextcloudIntegration/FileProviderExt/FileProviderExtension.swift | Removed guard clause that prevented trash deletion when disabled |
| shell_integration/MacOSX/NextcloudIntegration/FileProviderExt/FileProviderDomainDefaults.swift | Removed property implementations and marked key as obsolete |
馃挕 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Removed XPC APIs for trash state management. - Removed UserDefaults code about trash state management. - Removed checkbox from file provider settings tab. - Removed "Allow deletion of items in Trash" from English translations. Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
i2h3
force-pushed
the
i2h3/fix/stable-4.0-remove-trash-option
branch
from
January 16, 2026 07:33
f0fc97a to
d6bb5de
Compare
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-9322.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
i2h3
enabled auto-merge
January 16, 2026 07:47
github-project-automation
Bot
moved this from 馃Л Planning evaluation (don't pick)
to 鈽戯笍 Done
in 馃捇 Desktop Clients team
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.