[stable-3.17] fix(checksums): avoid crash on aborted checksum calculation job - #9096
Merged
Conversation
backportbot
Bot
requested review from
camilasan,
i2h3,
mgallien and
nilsding
as code owners
November 18, 2025 08:05
In case a propagation job is aborted while it's about to start computing
the content checksum in a thread, the thread could still be started and
attempting to call `_checksumCalculator->calculate()`. As the job was
aborted the ComputeChecksum instance has already been deleted along with
its ChecksumCalculator instance, and the thread ends up calling
`calculate()` on an invalid pointer.
I managed to occasionally reproduce this through:
auto computeChecksum = new ComputeChecksum();
computeChecksum->setChecksumType("MD5");
computeChecksum->start("/dev/zero");
delete computeChecksum;
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
camilasan
approved these changes
Nov 18, 2025
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-9096.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
nilsding
approved these changes
Nov 18, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #9039