Skip to content

[stable-3.16] fix(filesystem): ensure we set a file read-only or read-write on Windows - #8215

Merged
mgallien merged 5 commits into
stable-3.16from
backport/8209/stable-3.16
Apr 28, 2025
Merged

[stable-3.16] fix(filesystem): ensure we set a file read-only or read-write on Windows#8215
mgallien merged 5 commits into
stable-3.16from
backport/8209/stable-3.16

Conversation

@backportbot

@backportbot backportbot Bot commented Apr 28, 2025

Copy link
Copy Markdown

Backport of PR #8209

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
on Windows we may fail to mark a file read-only be read-write again
using high level API

switch to use of low level C API from Microsoft

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
we might forget to run the pending folder deletions when terminating
synchronization

ensure we check if any of them are to be done

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@backportbot
backportbot Bot requested review from mgallien and nilsding April 28, 2025 09:46
@backportbot backportbot Bot added this to the 3.16.4 milestone Apr 28, 2025
@mgallien
mgallien enabled auto-merge April 28, 2025 09:47
@github-actions

Copy link
Copy Markdown
Contributor

Artifact containing the AppImage: nextcloud-appimage-pr-8215.zip

SHA256 checksum: 7a039da973c86860e9b400390114c1e8e2932b004120143a50fe978838f6e674

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien
mgallien merged commit 3ba8763 into stable-3.16 Apr 28, 2025
@mgallien
mgallien deleted the backport/8209/stable-3.16 branch April 28, 2025 10:00
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
1 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant