fix(gui): resize sharee search results list dependent on required space - #8201
Merged
Conversation
nilsding
added
feature: 馃懃 sharing
nilsding
requested review from
camilasan,
claucambra and
mgallien
as code owners
April 24, 2025 11:49
Member
Author
|
/backport to stable-3.16 |
mgallien
approved these changes
Apr 28, 2025
In the case there are more search results present than there's space for it, always display a scrollbar. Some QtQuick themes don't make it obvious that the list is scrollable. Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
mgallien
force-pushed
the
bugfix/sharing-search-popup-sizing
branch
from
April 28, 2025 07:11
dd6a02b to
fe0140f
Compare
mgallien
enabled auto-merge
April 28, 2025 07:12
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-8201.zip SHA256 checksum: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some QtQuick themes don't make it obvious that the search results list is scrollable, leading to a confusing user experience.
With this PR the results list expands to the available space in the window. In the case the results do not fit the window, a scroll bar will be present as well now.