Skip to content

[stable-3.16] Bugfix/filesystem remove file not working #8197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgallien merged 2 commits into from
Apr 24, 2025
Merged

[stable-3.16] Bugfix/filesystem remove file not working #8197

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59f7c76
feat: better logs when a file cannot be removed
mgallien Apr 22, 2025
db8787d
fix: use safer conversion from QString to filesystem::path
mgallien Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/common/filesystembase.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,10 +591,11 @@ bool FileSystem::remove(const QString &fileName, QString *errorString)
#endif

try {
if (!std::filesystem::remove(std::filesystem::path{fileName.toUtf8().data()})) {
if (!std::filesystem::remove(std::filesystem::path{fileName.toStdWString()})) {
if (errorString) {
*errorString = QObject::tr("File is already deleted");
}
qCWarning(lcFileSystem()) << "File is already deleted" << fileName;
return false;
}
}
Expand All @@ -603,13 +604,15 @@ bool FileSystem::remove(const QString &fileName, QString *errorString)
if (errorString) {
*errorString = QString::fromLatin1(e.what());
}
qCWarning(lcFileSystem()) << e.what() << fileName;
return false;
}
catch (...)
{
if (errorString) {
*errorString = QObject::tr("Error deleting the file");
}
qCWarning(lcFileSystem()) << "Error deleting the file" << fileName;
return false;
}

Expand Down