[stable-3.16] Bugfix/read only windows folders - #8196
Merged
Conversation
mgallien
approved these changes
Apr 24, 2025
mgallien
enabled auto-merge
April 24, 2025 08:34
mgallien
disabled auto-merge
April 24, 2025 09:01
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
needed to download a new file inside a read-only folder Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
the sync engine will remove invalid items inside read-only folders not needed to remove them in tests and rather checks that they were indeed removed Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
current QDir::rmdir API does not provide an error message when failing to delete retuse FileSystem::remove that may just works with folders Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
mgallien
force-pushed
the
backport/8182/stable-3.16
branch
from
April 24, 2025 09:01
db09d12 to
710e5fa
Compare
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-8196.zip SHA256 checksum: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #8182