Skip to content

[stable-3.16] skip single test or whole test file for macOS: they are broken #8163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nilsding merged 1 commit into from
Apr 15, 2025
Merged

[stable-3.16] skip single test or whole test file for macOS: they are broken #8163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,9 @@ nextcloud_add_test(Utility)

if (NOT APPLE)
nextcloud_add_test(SyncEngine)
nextcloud_add_test(SyncVirtualFiles)
endif()

nextcloud_add_test(SyncVirtualFiles)
nextcloud_add_test(SyncMove)
nextcloud_add_test(SyncDelete)
nextcloud_add_test(SyncConflict)
Expand Down
4 changes: 4 additions & 0 deletions test/testfolderwatcher.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,10 @@ private slots:
}
void testDetectLockFilesExternally()
{
#if defined Q_OS_MACOS
QSKIP("not reliable on macOS");
#endif

QStringList listOfOfficeFiles = {QString(_rootPath + "/document.docx"), QString(_rootPath + "/document.odt")};
std::sort(std::begin(listOfOfficeFiles), std::end(listOfOfficeFiles));

Expand Down
4 changes: 4 additions & 0 deletions test/testsyncmove.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -976,6 +976,10 @@ private slots:

void testMovedWithError()
{
#if defined Q_OS_MACOS
QSKIP("not reliable on macOS");
#endif

QFETCH(Vfs::Mode, vfsMode);
const auto getName = [vfsMode] (const QString &s)
{
Expand Down