Translation adjustments - #8152
Merged
Merged
Conversation
nilsding
added
feature: 🗣️ localization
nilsding
requested review from
camilasan,
claucambra and
mgallien
as code owners
April 14, 2025 14:27
nilsding
commented
Apr 14, 2025
| QCOMPARE(model.userStatusEmoji(), userStatusIcon); | ||
| QCOMPARE(model.onlineStatus(), userStatusState); | ||
| QCOMPARE(model.clearAtDisplayString(), tr("1 day")); | ||
| QCOMPARE(model.clearAtDisplayString(), QStringLiteral("1 day(s)")); |
Member
Author
There was a problem hiding this comment.
Two things:
- I don't think that using
tris useful in tests --> replaced these withQStringLiteral()s - I'm also not sure if the translations are ever loaded within tests -- the various plural forms are part of those. For now I've changed these to the
(s)form as it's in the code as well...
nilsding
force-pushed
the
bugfix/translation-adjustments
branch
from
April 15, 2025 06:09
9297fc4 to
83f22a2
Compare
in German this ended up as "Datei Namen"/"Ordner Namen", whereas these should be compounds instead (i.e. "Dateinamen", "Ordnernamen") Fixes #7962 Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Many languages have different ways of handling plurals where checking for `n == 1` is simply not enough. Fixes #8149 Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
mgallien
force-pushed
the
bugfix/translation-adjustments
branch
from
April 24, 2025 10:39
83f22a2 to
e529195
Compare
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-8152.zip SHA256 checksum: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7962
Fixes #8149
I'm targeting this for 3.17.0 to give translators some time to adapt these strings.