[stable-3.16] Bugfix/slow bulk upload - #8139
Merged
Merged
Conversation
mgallien
force-pushed
the
backport/8048/stable-3.16
branch
from
April 10, 2025 12:50
dfb1a93 to
6ca3307
Compare
mgallien
marked this pull request as ready for review
April 10, 2025 12:50
mgallien
approved these changes
Apr 10, 2025
mgallien
enabled auto-merge
April 10, 2025 12:50
mgallien
force-pushed
the
backport/8048/stable-3.16
branch
from
April 10, 2025 12:51
6ca3307 to
3a46600
Compare
- Cancel sync after try with smaller bulk upload batch size also throws error. - Continue syncing when there is no error. - Remove file from bulk upload black list only when upload succeeded. Signed-off-by: Camila <hello@camila.codes>
Signed-off-by: Camila Ayres <hello@camilasan.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
should help make it faster to send all data Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
data of the files are ready in a memory buffer so Qt will not buffer them anyway Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
will be important to try to see upload performance bottlenecks Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
mgallien
force-pushed
the
backport/8048/stable-3.16
branch
from
April 10, 2025 12:56
3a46600 to
b352ab5
Compare
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-8139.zip SHA256 checksum: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #8048
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.