Skip to content

[stable-3.16] fix: try to correct mtime on upsyncs - #8131

Merged
nilsding merged 2 commits into
stable-3.16from
backport/8095/stable-3.16
Apr 9, 2025
Merged

[stable-3.16] fix: try to correct mtime on upsyncs#8131
nilsding merged 2 commits into
stable-3.16from
backport/8095/stable-3.16

Conversation

@backportbot

@backportbot backportbot Bot commented Apr 9, 2025

Copy link
Copy Markdown

Backport of PR #8095

nilsding added 2 commits April 9, 2025 07:13
Files with a modification time of less than 0 do usually not make sense
(and afaik the server doesn't accept them either).
--> attempt to update the modification time to _Time.now_ while
propagating

side note: I ran into this because KArchive/Ark(?) didn't consider the
extra time attributes on entries for a certain zip file, so it instead
used the standard time value of each zip entry which was set to <= 1980
for files and < 1970 for directories...

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
also removes some unused Utility methods

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
@backportbot
backportbot Bot requested review from mgallien and nilsding April 9, 2025 07:13
@backportbot backportbot Bot added this to the 3.16.3 milestone Apr 9, 2025
@nilsding
nilsding enabled auto-merge April 9, 2025 07:14
@github-actions

github-actions Bot commented Apr 9, 2025

Copy link
Copy Markdown
Contributor

Artifact containing the AppImage: nextcloud-appimage-pr-8131.zip

SHA256 checksum: 41b6ea945656c20e62b15e975db6e190810de28ee5a640e1ca61d92134f4a4a0

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@nilsding
nilsding merged commit a74fa57 into stable-3.16 Apr 9, 2025
@nilsding
nilsding deleted the backport/8095/stable-3.16 branch April 9, 2025 07:26
@sonarqubecloud

sonarqubecloud Bot commented Apr 9, 2025

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
68.0% Coverage on New Code (required ≥ 80%)
2 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant