feat: build Windows installer with translations embedded - #8103
Conversation
nilsding
added
os: 🚪 Windows
feature: 📥 install and update
feature: 🗣️ localization
the base translations come from WixUI itself There are still some untranslated strings in Nextcloud.wxs, we need to take care of them at a later point. As a first step this is good enough. This commit serves as a proof-of-concept, the languages I used here will change depending on what we want to support. Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
building all the translated installers takes about ~1 minute each, so keep that in mind when adding extra translations ... Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
1632011 to
a6a17e3
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-8103.zip SHA256 checksum: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
|
The installer will be offered in the language |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
2 participants
This PR changes the MSI to contain multiple languages, changing the installer's language to the system language.
Each additional language will add about ~1 minute of build time, as the MSI needs to be re-built for each language to create a patch/transform file. This transform file will only contain the difference from the base English installer and will be applied automatically by Windows Installer itself.
Note: we have some hardcoded strings in the
Nextcloud.wxsfile which won't be translated just yet. As the first step I want to make sure our builds work fine with the core translations provided by WiX, after that I'll take a look at how these can be translated (ideally with Transifex integration)This PR requires some change in nextcloud/client-building, PR in: nextcloud/client-building#141