Skip to content

chore(Flow2Auth): modernize fetchNewToken. - #8098

Merged
mgallien merged 8 commits into
masterfrom
add/loginflowheader
Apr 14, 2025
Merged

chore(Flow2Auth): modernize fetchNewToken. #8098
mgallien merged 8 commits into
masterfrom
add/loginflowheader

Conversation

@camilasan

@camilasan camilasan commented Mar 31, 2025

Copy link
Copy Markdown
Member

No description provided.

@camilasan camilasan changed the title fix(Flow2Auth): add header OCS-APIREQUEST to request. WIP: fix(Flow2Auth): add header OCS-APIREQUEST to request. Mar 31, 2025
@camilasan
camilasan marked this pull request as draft March 31, 2025 18:51
@camilasan
camilasan force-pushed the add/loginflowheader branch from c0054d7 to 9f68d07 Compare March 31, 2025 19:01
@camilasan camilasan changed the title WIP: fix(Flow2Auth): add header OCS-APIREQUEST to request. chore(Flow2Auth): modernize fetchNewToken. Mar 31, 2025
@camilasan
camilasan marked this pull request as ready for review March 31, 2025 19:26
@camilasan
camilasan marked this pull request as draft March 31, 2025 19:27
@camilasan camilasan changed the title chore(Flow2Auth): modernize fetchNewToken. WIP: chore(Flow2Auth): modernize fetchNewToken. Mar 31, 2025
@camilasan camilasan added this to the 3.17.0 milestone Apr 10, 2025
@camilasan
camilasan force-pushed the add/loginflowheader branch from e3012a0 to a69c810 Compare April 10, 2025 12:21
@camilasan
camilasan marked this pull request as ready for review April 10, 2025 12:21
@camilasan camilasan changed the title WIP: chore(Flow2Auth): modernize fetchNewToken. chore(Flow2Auth): modernize fetchNewToken. Apr 10, 2025
Comment thread src/gui/creds/flow2auth.cpp
Comment thread src/gui/creds/flow2auth.cpp Outdated
Comment thread src/gui/creds/flow2auth.cpp Outdated
@camilasan
camilasan force-pushed the add/loginflowheader branch 2 times, most recently from 74be0c0 to 8de7bca Compare April 10, 2025 15:54
@mgallien
mgallien force-pushed the add/loginflowheader branch from 9b0c87c to 519a8bd Compare April 11, 2025 06:55
@mgallien
mgallien enabled auto-merge April 11, 2025 06:55
Signed-off-by: Camila Ayres <hello@camilasan.com>
Signed-off-by: Camila Ayres <hello@camilasan.com>
Signed-off-by: Camila Ayres <hello@camilasan.com>
Move part of the server repsonse logic to another function.

Signed-off-by: Camila Ayres <hello@camilasan.com>
Move part of the server repsonse logic to another function.

Signed-off-by: Camila Ayres <hello@camilasan.com>
Signed-off-by: Camila Ayres <hello@camilasan.com>
Signed-off-by: Camila Ayres <hello@camilasan.com>
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
camilasan force-pushed the add/loginflowheader branch from 519a8bd to d272074 Compare April 14, 2025 17:50
@github-actions

Copy link
Copy Markdown
Contributor

Artifact containing the AppImage: nextcloud-appimage-pr-8098.zip

SHA256 checksum: 8eb69234e7f815f420fe00e678a76cfea94a6d9ab4279c0945a3d04906e03378

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
7 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@mgallien
mgallien merged commit 3fd849b into master Apr 14, 2025
@mgallien
mgallien deleted the add/loginflowheader branch April 14, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants