feat: allow overriding the language through the configuration - #8096
Conversation
mgallien
left a comment
There was a problem hiding this comment.
the application suddenly stop if the forced translation does not exist
maybe the command line could provide a hint why the application is stopping or even better fallback to the default locale
66bdf57 to
12ed3d6
Compare
|
changed the CLI option to if it's set to invalid values Qt will not load any language either |
e.g. this config entry: ```ini ; nextcloud.cfg [General] language=de ``` will ensure that the application will always be translated to German. It's also possible to set the configuration option from the command line: ```sh # set the language to German for the next client startup ./nextcloud --set-language de # set the language to the OS default for the next client startup ./nextcloud --set-language "" ``` partial fix for #111, as this is not a GUI option Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org> # Date: Mon Mar 31 12:44:55 2025 +0200 # # On branch feature/enforce-translations # Your branch and 'origin/feature/enforce-translations' have diverged, # and have 1 and 1 different commits each, respectively. # # Changes to be committed: # modified: src/gui/application.cpp # modified: src/gui/application.h # modified: src/libsync/configfile.cpp # modified: src/libsync/configfile.h # # Untracked files: # .kateproject.build # metainfo.po # test.metainfo.xml #
12ed3d6 to
1998d33
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-8096.zip SHA256 checksum: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |



e.g. this config entry:
will ensure that the application will always be translated to German.
It's also possible to set the configuration option from the command line:
partial fix for #111, as this is not a GUI option