Widen account wizard so localized button labels fit - #10907
Merged
Merged
Conversation
i2h3
requested review from
camilasan,
claucambra,
mgallien and
nilsding
as code owners
September 23, 2026 11:41
i2h3
added
bug
os: 🍎 macOS
github-project-automation
Bot
moved this to 🧭 Planning evaluation (don't pick)
in 💻 Desktop Clients team
Collaborator
Author
|
/backport to stable-34.0 |
i2h3
moved this from 🧭 Planning evaluation (don't pick)
to 🏗️ In progress
in 💻 Desktop Clients team
The folder step's footer splits its width equally between four buttons, so at 600 px the German "Später einrichten" and "Fortgeschritten" were truncated. The "Choose" button had a fixed width of 96 px, which cut off "Auswählen". French ("Configurer plus tard") and Spanish ("Configurar más tarde") are truncated in the same footer as well.
Use a new Style.accountWizardWidth of 720 px as width and minimum width for every wizard step, so the window does not change width between steps. Give the "Choose" button a minimum width of 96 px and let it grow with its label. This fixes German; the French and Spanish "Set up later" labels still do not fit at 720 px and would need about 820 px or content-sized footer buttons.
Add a QML test that loads AccountWizardWindow with a mock controller and checks the width across steps, the German footer labels (macOS only, since the width was measured with the macOS system font) and the "Choose" button sizing.
Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
i2h3
force-pushed
the
i2h3/fix/wizard-width
branch
from
September 23, 2026 11:43
8cf5366 to
7aa446c
Compare
|
github-project-automation
Bot
moved this from 🏗️ In progress
to ☑️ Done
in 💻 Desktop Clients team
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The folder step's footer splits its width equally between four buttons, so at 600 px the German "Später einrichten" and "Fortgeschritten" were truncated. The "Choose" button had a fixed width of 96 px, which cut off "Auswählen". French ("Configurer plus tard") and Spanish ("Configurar más tarde") are truncated in the same footer as well.
Use a new Style.accountWizardWidth of 720 px as width and minimum width for every wizard step, so the window does not change width between steps. Give the "Choose" button a minimum width of 96 px and let it grow with its label. This fixes German; the French and Spanish "Set up later" labels still do not fit at 720 px and would need about 820 px or content-sized footer buttons.
Add a QML test that loads AccountWizardWindow with a mock controller and checks the width across steps, the German footer labels (macOS only, since the width was measured with the macOS system font) and the "Choose" button sizing.
Comparison
Checklist
AI (if applicable)