Skip to content

fix(shell_integration): use title case for macOS and Linux context menus #10718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cbrnr wants to merge 1 commit into from
Closed

fix(shell_integration): use title case for macOS and Linux context menus #10718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions shell_integration/MacOSX/NextcloudIntegration/FileProviderExt/Info.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
<key>Label</key>
<dict>
<key>NSStringFormat</key>
<string>Always keep downloaded</string>
<string>Always Keep Downloaded</string>
</dict>
</dict>
</array>
Expand All @@ -43,55 +43,55 @@
<key>NSExtensionFileProviderActionIdentifier</key>
<string>com.nextcloud.desktopclient.FileProviderExt.KeepDownloadedAction</string>
<key>NSExtensionFileProviderActionName</key>
<string>Always keep downloaded</string>
<string>Always Keep Downloaded</string>
</dict>
<dict>
<key>NSExtensionFileProviderActionActivationRule</key>
<string>SUBQUERY ( fileproviderItems, $fileproviderItem, $fileproviderItem.userInfo.displayAllowAutoEvicting == true ).@count &gt; 0</string>
<key>NSExtensionFileProviderActionIdentifier</key>
<string>com.nextcloud.desktopclient.FileProviderExt.AutoEvictAction</string>
<key>NSExtensionFileProviderActionName</key>
<string>Allow automatic freeing up space</string>
<string>Allow Automatic Freeing Up Space</string>
</dict>
<dict>
<key>NSExtensionFileProviderActionActivationRule</key>
<string>SUBQUERY ( fileproviderItems, $fileproviderItem, $fileproviderItem.userInfo.displayEvict == true ).@count &gt; 0</string>
<key>NSExtensionFileProviderActionIdentifier</key>
<string>com.nextcloud.desktopclient.FileProviderExt.EvictAction</string>
<key>NSExtensionFileProviderActionName</key>
<string>Remove download</string>
<string>Remove Download</string>
</dict>
<dict>
<key>NSExtensionFileProviderActionActivationRule</key>
<string>SUBQUERY ( fileproviderItems, $fileproviderItem, $fileproviderItem.userInfo.displayEvictDescendants == true ).@count &gt; 0</string>
<key>NSExtensionFileProviderActionIdentifier</key>
<string>com.nextcloud.desktopclient.FileProviderExt.EvictDescendantsAction</string>
<key>NSExtensionFileProviderActionName</key>
<string>Remove downloaded items</string>
<string>Remove Downloaded Items</string>
</dict>
<dict>
<key>NSExtensionFileProviderActionActivationRule</key>
<string>SUBQUERY ( fileproviderItems, $fileproviderItem, $fileproviderItem.userInfo.displayFileActions == true ).@count &gt; 0</string>
<key>NSExtensionFileProviderActionIdentifier</key>
<string>com.nextcloud.desktopclient.FileProviderExt.FileActionsAction</string>
<key>NSExtensionFileProviderActionName</key>
<string>File actions</string>
<string>File Actions</string>
</dict>
<dict>
<key>NSExtensionFileProviderActionActivationRule</key>
<string>SUBQUERY ( fileproviderItems, $fileproviderItem, $fileproviderItem.userInfo.displayOpenInBrowser == true ).@count &gt; 0</string>
<key>NSExtensionFileProviderActionIdentifier</key>
<string>com.nextcloud.desktopclient.FileProviderExt.OpenInBrowserAction</string>
<key>NSExtensionFileProviderActionName</key>
<string>Open in browser</string>
<string>Open in Browser</string>
</dict>
<dict>
<key>NSExtensionFileProviderActionActivationRule</key>
<string>SUBQUERY ( fileproviderItems, $fileproviderItem, $fileproviderItem.userInfo.displayCopyInternalLink == true ).@count &gt; 0</string>
<key>NSExtensionFileProviderActionIdentifier</key>
<string>com.nextcloud.desktopclient.FileProviderExt.CopyInternalLinkAction</string>
<key>NSExtensionFileProviderActionName</key>
<string>Copy internal link</string>
<string>Copy Internal Link</string>
</dict>
</array>
<key>NSExtensionFileProviderAllowsContextualMenuDownloadEntry</key>
Expand Down
42 changes: 21 additions & 21 deletions shell_integration/MacOSX/NextcloudIntegration/FileProviderExt/Localizable.xcstrings
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"sourceLanguage" : "en",
"strings" : {
"Allow automatic freeing up space" : {
"Allow Automatic Freeing Up Space" : {
"comment" : "Context menu item label.",
"extractionState" : "manual",
"localizations" : {
Expand All @@ -26,13 +26,13 @@
"en" : {
"stringUnit" : {
"state" : "translated",
"value" : "Allow automatic freeing up space"
"value" : "Allow Automatic Freeing Up Space"
}
},
"en_GB" : {
"stringUnit" : {
"state" : "translated",
"value" : "Allow automatic freeing up space"
"value" : "Allow Automatic Freeing Up Space"
}
},
"es" : {
Expand Down Expand Up @@ -139,7 +139,7 @@
}
}
},
"Always keep downloaded" : {
"Always Keep Downloaded" : {
"comment" : "Context menu item label.",
"extractionState" : "manual",
"localizations" : {
Expand All @@ -164,13 +164,13 @@
"en" : {
"stringUnit" : {
"state" : "translated",
"value" : "Always keep downloaded"
"value" : "Always Keep Downloaded"
}
},
"en_GB" : {
"stringUnit" : {
"state" : "translated",
"value" : "Always keep downloaded"
"value" : "Always Keep Downloaded"
}
},
"es" : {
Expand Down Expand Up @@ -415,7 +415,7 @@
}
}
},
"Copy internal link" : {
"Copy Internal Link" : {
"comment" : "Context menu item label.",
"extractionState" : "manual",
"localizations" : {
Expand Down Expand Up @@ -476,13 +476,13 @@
"en" : {
"stringUnit" : {
"state" : "translated",
"value" : "Copy internal link"
"value" : "Copy Internal Link"
}
},
"en_GB" : {
"stringUnit" : {
"state" : "translated",
"value" : "Copy internal link"
"value" : "Copy Internal Link"
}
},
"es" : {
Expand Down Expand Up @@ -775,7 +775,7 @@
}
}
},
"File actions" : {
"File Actions" : {
"comment" : "Context menu item label.",
"extractionState" : "manual",
"localizations" : {
Expand Down Expand Up @@ -836,13 +836,13 @@
"en" : {
"stringUnit" : {
"state" : "translated",
"value" : "File actions"
"value" : "File Actions"
}
},
"en_GB" : {
"stringUnit" : {
"state" : "translated",
"value" : "File actions"
"value" : "File Actions"
}
},
"es" : {
Expand Down Expand Up @@ -1063,7 +1063,7 @@
}
}
},
"Open in browser" : {
"Open in Browser" : {
"comment" : "Context menu item label.",
"extractionState" : "manual",
"localizations" : {
Expand Down Expand Up @@ -1142,13 +1142,13 @@
"en" : {
"stringUnit" : {
"state" : "translated",
"value" : "Open in browser"
"value" : "Open in Browser"
}
},
"en_GB" : {
"stringUnit" : {
"state" : "translated",
"value" : "Open in browser"
"value" : "Open in Browser"
}
},
"eo" : {
Expand Down Expand Up @@ -1477,7 +1477,7 @@
}
}
},
"Remove download" : {
"Remove Download" : {
"comment" : "Context menu item label.",
"extractionState" : "manual",
"localizations" : {
Expand All @@ -1496,13 +1496,13 @@
"en" : {
"stringUnit" : {
"state" : "translated",
"value" : "Remove download"
"value" : "Remove Download"
}
},
"en_GB" : {
"stringUnit" : {
"state" : "translated",
"value" : "Remove download"
"value" : "Remove Download"
}
},
"et_EE" : {
Expand Down Expand Up @@ -1555,7 +1555,7 @@
}
}
},
"Remove downloaded items" : {
"Remove Downloaded Items" : {
"comment" : "Context menu item label.",
"extractionState" : "manual",
"localizations" : {
Expand All @@ -1574,13 +1574,13 @@
"en" : {
"stringUnit" : {
"state" : "translated",
"value" : "Remove downloaded items"
"value" : "Remove Downloaded Items"
}
},
"en_GB" : {
"stringUnit" : {
"state" : "translated",
"value" : "Remove downloaded items"
"value" : "Remove Downloaded Items"
}
},
"et_EE" : {
Expand Down
8 changes: 4 additions & 4 deletions shell_integration/MacOSX/NextcloudIntegration/FileProviderUIExt/Info.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,31 +27,31 @@
<key>NSExtensionFileProviderActionIdentifier</key>
<string>com.nextcloud.desktopclient.FileProviderUIExt.UnlockFileAction</string>
<key>NSExtensionFileProviderActionName</key>
<string>Unlock file</string>
<string>Unlock File</string>
</dict>
<dict>
<key>NSExtensionFileProviderActionActivationRule</key>
<string>SUBQUERY ( fileproviderItems, $fileproviderItem, $fileproviderItem.userInfo.locked == nil &amp;&amp; !($fileproviderItem.contentType.identifier UTI-CONFORMS-TO "public.folder") ).@count &gt; 0</string>
<key>NSExtensionFileProviderActionIdentifier</key>
<string>com.nextcloud.desktopclient.FileProviderUIExt.LockFileAction</string>
<key>NSExtensionFileProviderActionName</key>
<string>Lock file</string>
<string>Lock File</string>
</dict>
<dict>
<key>NSExtensionFileProviderActionActivationRule</key>
<string>SUBQUERY ( fileproviderItems, $fileproviderItem, $fileproviderItem.userInfo.displayShare == true ).@count &gt; 0</string>
<key>NSExtensionFileProviderActionIdentifier</key>
<string>com.nextcloud.desktopclient.FileProviderUIExt.ShareAction</string>
<key>NSExtensionFileProviderActionName</key>
<string>Share options</string>
<string>Share Options</string>
</dict>
<dict>
<key>NSExtensionFileProviderActionActivationRule</key>
<string>SUBQUERY ( fileproviderItems, $fileproviderItem, $fileproviderItem.userInfo.downloaded == true ).@count &gt; 0</string>
<key>NSExtensionFileProviderActionIdentifier</key>
<string>com.nextcloud.desktopclient.FileProviderUIExt.EvictAction</string>
<key>NSExtensionFileProviderActionName</key>
<string>Free up space</string>
<string>Free Up Space</string>
</dict>
</array>
<key>NSExtensionPointIdentifier</key>
Expand Down
Loading