style(cmake): remove redundant conditions from endif/endfunction/endmacro/endforeach - #10707
Conversation
artyom-fedosov
commented
Sep 1, 2026
artyom-fedosov
commented
- Removed conditions repeated in endif()/endforeach()/endmacro()/endfunction() calls
- Removed the explicit cmake_policy(SET CMP0071 NEW) call
- Changed the value of CMAKE_CXX_STANDARD_REQUIRED to 20 instead of ON
- Removed a duplicated COMPONENTS keyword in find_package
|
Hello, can you please leave a note on the why? |
Rello
added
the
needs info
Hello, Explanations for each change are in the individual commit messages. At a high level: I removed legacy CMake constructs to improve readability and fixed a couple of small bugs. |
github-actions
Bot
removed
the
needs info
|
@artyom-fedosov thanks for the contribution. Next time use the PR template, it is there for a reason. That is where you should give us an overview of why the changes. |
…acro/endforeach Repeating the opening command's arguments in closing commands is a legacy CMake requirement dropped since CMake 3.13. Since the project requires CMake at least 3.16, the arguments are unnecessary. Signed-off-by: artyom-fedosov <artjomsfedosovs2@gmail.com>
CMAKE_CXX_STANDARD_REQUIRED expects a boolean not a standard version number Signed-off-by: artyom-fedosov <artjomsfedosovs2@gmail.com>
cmake_minimum_required(VERSION 3.16) already implies NEW behavior for CMP0071 Signed-off-by: artyom-fedosov <artjomsfedosovs2@gmail.com>
Signed-off-by: artyom-fedosov <artjomsfedosovs2@gmail.com>
e000f42 to
5ef182c
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-10707.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
5 participants
