fix(cmake): set cmake var APPLICATION_REV_DOMAIN_INSTALLER - #10699
Merged
Conversation
camilasan
force-pushed
the
bugfix/noid/overwritelegacyclient
branch
from
August 31, 2026 12:59
ae1bddc to
aaf9f1d
Compare
camilasan
changed the title
Use a legacy installer identifier for migrating a branded client to a new bundle identifier, letting PackageKit recognize the new package as an upgrade of the existing receipt. Signed-off-by: Camila Ayres <camila.ayres@nextcloud.com>
Enables atomic replacement of the outer @APPLICATION_NAME@.app
payload during install/upgrade instead of PackageKit's default
file by file diff.
Without this, installing a rebranded client over an existing
install like a legacy client receipt being upgraded
via APPLICATION_REV_DOMAIN_INSTALLER can leave stale files from
the previous bundle mixed with the new payload, producing an
invalid code signature ("a sealed resource is missing or
invalid") that fails Gatekeeper/launchd validation on next boot.
Signed-off-by: Camila Ayres <camila.ayres@nextcloud.com>
camilasan
force-pushed
the
bugfix/noid/overwritelegacyclient
branch
from
August 31, 2026 17:21
aaf9f1d to
6907af3
Compare
camilasan
marked this pull request as ready for review
August 31, 2026 17:21
camilasan
requested review from
claucambra,
i2h3,
mgallien and
nilsding
as code owners
August 31, 2026 17:21
|
Member
Author
|
/backport to stable-34.0 |
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-10699.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
nilsding
approved these changes
Sep 1, 2026
claucambra
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
It allows the client to install over another legacy client on macOS.
Without this, installing a rebranded client over an existing install like a legacy client receipt being upgraded via APPLICATION_REV_DOMAIN_INSTALLER can leave stale files from the previous bundle mixed with the new payload, producing an invalid code signature ("a sealed resource is missing or invalid") that fails Gatekeeper/launchd validation on next boot.
To do
Checklist
AI (if applicable)