[stable-34.0] fix(tray): GNOME + AppIndicator compatibility - #10664
Merged
Conversation
backportbot
Bot
requested review from
camilasan,
claucambra,
i2h3,
mgallien and
nilsding
as code owners
August 25, 2026 09:32
claucambra
approved these changes
Aug 25, 2026
mgallien
approved these changes
Aug 25, 2026
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-10664.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
The account submenu does not work in a standard (Ubuntu) GNOME environment, for the following reasons: * If the submenu is empty, no `aboutToShow` event is sent. This patch pre-populates the submenu. * If the submenu is updated when handling `aboutToShow`, it will be closed immediately. This patch causes the event handler to only fetch the activities in this case. It will still enable dynamic updates for KDE, i.e. `dataChanged` will be called. In case of GNOME, however, the menu is not marked visible, thus the `dataChanged` handler will not update (and thus close) the menu. However, since the tray menu is built when opening, the contents will be relatively recent even there, though not updating. Signed-off-by: Istv谩n V谩radi <ivaradi@varadiistvan.hu>
mgallien
enabled auto-merge
August 25, 2026 11:00
mgallien
force-pushed
the
backport/10646/stable-34.0
branch
from
August 25, 2026 11:00
1cca309 to
afa5afe
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #10646