Chore/improve clang format configuration - #10663
Merged
Merged
Conversation
mgallien
requested review from
camilasan,
claucambra,
i2h3 and
nilsding
as code owners
August 25, 2026 09:17
Collaborator
Author
|
/backport to stable-34.0 please |
claucambra
approved these changes
Aug 25, 2026
mgallien
force-pushed
the
chore/applyClangFormat
branch
from
August 25, 2026 10:00
e5e598b to
c9a2685
Compare
switch to ubuntu-26.04 to get more recent clang-format Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
should enable clang-format to check for missing braces this is also limited by its inability to have a full code representation that is what clang-tidy is made for Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
should also improve readibility Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com> Assisted-by: ClaudeCode:claude-sonnet-5
mgallien
enabled auto-merge
August 25, 2026 19:02
mgallien
force-pushed
the
chore/applyClangFormat
branch
from
August 25, 2026 19:02
c9a2685 to
28d5ceb
Compare
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-10663.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
try to make our existing clang-format configuration to be closer to what we want
also try to make the existing CI works better
also try to enable pre-commit clang-format checks via KDE's ECM
also try to improve results from AI coding agents with regard to code format
Resolves
#
Summary
TODO
Checklist
AI (if applicable)