fix(file-provider): Correctly enumerate large change batches - #10660
Conversation
5d239c7 to
9e6e9aa
Compare
|
tested on my side
|
|
/backport to stable-34.0 please |
| final sync anchor instead of a continuation anchor. | ||
|
|
||
| The framework may invalidate the current `Enumerator` after an intermediate | ||
| batch and create another one for the next request. The extension process may |
There was a problem hiding this comment.
Argh… The framework always is good for surprises like these. The best part: it can change any time. 🙄
| /// A thread-safe FIFO buffer of change metadata still to be delivered to an | ||
| /// `NSFileProviderChangeObserver` across the successive `enumerateChanges(for:from:)` invocations the | ||
| /// framework drives with `moreComing: true`. | ||
| /// Durable FIFO state for a multi-batch File Provider change enumeration. |
There was a problem hiding this comment.
It is a bit odd wording, I would have used the conventional "persistent" because "durable" sounds more like bicycle tires. 😅 Not an issue, though.
|
Artifact containing the AppImage: nextcloud-appimage-pr-10660.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
…ivery types Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
…re used during change enumeration Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
…on completed Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
0b1e7e8 to
95d1d20
Compare
|



Resolves
#10556
Summary
We had issues with the batched change reporting in the enumerator.
Issue Reproduction
The unchanged-anchor bug reproduced successfully.
The current macOS version did not retain the literal “token is unchanged” message, but the daemon’s anchor remained unchanged and no updated: 7, moreComing: false batch occurred. The behavior is therefore confirmed directly.
Checklist
AI (if applicable)