fix(db): avoid printing misleading warning logs - #10650
Merged
Merged
Conversation
mgallien
requested review from
camilasan,
claucambra,
i2h3 and
nilsding
as code owners
August 24, 2026 12:56
claucambra
approved these changes
Aug 24, 2026
Collaborator
Author
|
/backport to stable-34.0 please |
mgallien
enabled auto-merge
August 24, 2026 13:03
|
would have printed this very useless and misleading warning in the logs: syncjournaldb.cpp:1285 ]: database error: "" this is in fact not an error but a lack of data Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
mgallien
force-pushed
the
bugfix/doNotPrintEmptyDbErrors
branch
from
August 24, 2026 13:47
e3bddbd to
b3be55e
Compare
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-10650.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
would have printed this very useless and misleading warning in the logs: syncjournaldb.cpp:1285 ]: database error: ""
this is in fact not an error but a lack of data
Resolves
#
Summary
TODO
Checklist
AI (if applicable)