feat(search): revive unified search by Rello · Pull Request #10639 · nextcloud/desktop

Rello · 2026-08-21T08:22:14Z

Modernize the account-scoped search window with provider, date, and people filters, connected-service results, and aggregate and provider detail views.
Introduce cancellable per-provider search state, stable reveal ordering, stale-response protection, pagination, scoped retries, and persistent keyboard selection.
Align the search UI with shared wizard styling and add coverage for the search models, QML behavior, people lookup, and image handling.

Server Reference: nextcloud/server#60241

Assisted-by: Codex:GPT-5

Bildschirmaufnahme.2026-08-21.um.11.22.02.mov

Rello · 2026-08-21T09:24:21Z

@kra-mo as discussed

kra-mo

Since this is already a fixed-height dialog, there is no reason to show a filter button in the initial state. Instead, the filters should just always be visible.

There should also be some indication that a search is happening through a circular progress indicator like on the web. Right now, the search button seems to disappear while you're searching?

And are you struggling to click some of the buttons in the screen recording? I guess that is known, then :)

kra-mo · 2026-08-21T10:59:52Z

Since this is already a fixed-height dialog, there is no reason to show a filter button in the initial state. Instead, the filters should just always be visible.

Alternatively, we could make it variable-height, like Spotlight, which might also be nice.

Rello · 2026-08-21T11:03:07Z

Since this is already a fixed-height dialog, there is no reason to show a filter button in the initial state. Instead, the filters should just always be visible.

Alternatively, we could make it variable-height, like Spotlight, which might also be nice.

Hi,
you mean type/date/people buttons should be there from the beginning, correct?
I would like to keep it fixed height because this is stable. trying with dynamic and max-heigt is not used yet. Would add some more complexity. now we have the standard for all

kra-mo · 2026-08-21T11:15:04Z

Hi,
you mean type/date/people buttons should be there from the beginning, correct?

Yes, instead of having a funnel button.

I would like to keep it fixed height because this is stable. trying with dynamic and max-heigt is not used yet. Would add some more complexity. now we have the standard for all

Sure, makes sense

Rello · 2026-08-22T14:11:52Z

@kra-mo should be fine now

Bildschirmaufnahme.2026-08-22.um.16.11.20.mov

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5cfeaeaac6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

kra-mo

@Rello the 🔍 icon still disappears and there is still no progress indication.

Rello · 2026-08-24T14:48:02Z

@Rello the 🔍 icon still disappears and there is still no progress indication.

Ah. I think it tries to put the progress indicator where the search icon is.
question is where to put it? always at the bottom of all results? ...because of the "load more" for example...

kra-mo · 2026-08-25T07:24:52Z

Where it is on the web. At the end of the bar, just before the X button:

Rello · 2026-08-25T11:40:48Z

Where it is on the web. At the end of the bar, just before the X button:

Hi,
final approval like this?

kra-mo

Sure. It's an improvement over what there is atm.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 08df11544b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Rello · 2026-08-25T11:49:16Z

@copilot resolve the merge conflicts in this pull request

Copilot · 2026-08-25T12:10:00Z

@copilot resolve the merge conflicts in this pull request

Resolved the merge conflicts and pushed the merge commit in 5d490ea.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cefa5a12d7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 717974c845

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

claucambra

A few more comments, several of my prior comments remain unaddressed

claucambra · 2026-08-31T08:37:33Z

+ * SPDX-License-Identifier: GPL-2.0-or-later
+ */
+
+pragma ComponentBehavior: Bound


I don't think this is necessary here, there is only one root component?

Still present

I would actually recommand to put pragma ComponentBehavior: Bound in new qml files. This allow the QML engine to enable some optimizations and will be the default behavior in Qt7.

e.g. in Tokodon we already put that in every file

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bb11971d14

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4e56db3fa9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

claucambra · 2026-09-02T03:09:21Z

+ * SPDX-License-Identifier: GPL-2.0-or-later
+ */
+
+pragma ComponentBehavior: Bound


Still present

Modernize the account-scoped search window with provider, date, and people filters, connected-service results, and aggregate and provider detail views. Introduce per-provider search state, pagination, scoped retries, keyboard selection, shared wizard styling, and model and QML coverage. Co-authored-by: Matthieu Gallien <matthieu.gallien@nextcloud.com> Signed-off-by: Rello <github@scherello.de> Assisted-by: Codex:GPT-5

Signed-off-by: Rello <github@scherello.de> Assisted-by: Codex:GPT-5

Import tray QML types explicitly and default-initialize search result value members. Signed-off-by: Rello <github@scherello.de> Assisted-by: Codex:GPT-5

Signed-off-by: Rello <github@scherello.de> Assisted-by: Codex:GPT-5

github-actions · 2026-09-02T10:13:32Z

Artifact containing the AppImage: nextcloud-appimage-pr-10639.zip

Digest: sha256:91d262f94cc96c349572b5b469e9781a90a6c7a16811ee45c02ce887aaffda0d

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

Signed-off-by: Rello <github@scherello.de> Assisted-by: Codex:GPT-5

sonarqubecloud · 2026-09-02T11:54:46Z

Quality Gate failed

Failed conditions
79.6% Coverage on New Code (required ≥ 80%)
107 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

claucambra · 2026-09-02T12:53:49Z

-    QString _title;
-    QString _subline;
-    QString _providerId;
-    QString _providerName;
+    QString _title = QString();
+    QString _subline = QString();
+    QString _providerId = QString();
+    QString _providerName = QString();
+    QString _providerIcon = QString();
+    QString _stableKey = QString();
    bool _isRounded = false;
+    bool _isSelected = false;
+    bool _isSelectable = false;
+    bool _isPartialMatch = false;
+    bool _hasOverflow = false;
+    bool _isLoading = false;
    qint32 _order = std::numeric_limits<qint32>::max();
-    QUrl _resourceUrl;
-    QString _darkIcons;
-    QString _lightIcons;
+    QUrl _resourceUrl = QUrl();
+    QString _darkIcons = QString();
+    QString _lightIcons = QString();


We don't need to assign a value here either... e.g. QUrl resourceUrl generates a QUrl object already

Rello added this to the 35.0.0 milestone Aug 21, 2026

Rello self-assigned this Aug 21, 2026

Rello added the design Design, UI, UX, etc. label Aug 21, 2026

Rello moved this to NC35 in 💻 Desktop Clients team Aug 21, 2026

Rello added this to 💻 Desktop Clients team Aug 21, 2026

kra-mo requested changes Aug 21, 2026

View reviewed changes

Rello force-pushed the feature/newSearch branch from 69c9e0a to 5cfeaea Compare August 22, 2026 14:13

Rello marked this pull request as ready for review August 22, 2026 14:13

Rello requested review from camilasan, claucambra, i2h3, mgallien and nilsding as code owners August 22, 2026 14:13

chatgpt-codex-connector Bot reviewed Aug 22, 2026

View reviewed changes

Comment thread src/gui/search/UnifiedSearchInputContainer.qml Outdated

Rello force-pushed the feature/newSearch branch 4 times, most recently from 860dcd2 to 7920816 Compare August 22, 2026 18:22

kra-mo requested changes Aug 24, 2026

View reviewed changes

kra-mo approved these changes Aug 25, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Aug 25, 2026

View reviewed changes

Comment thread src/gui/search/unifiedsearchpeoplemodel.cpp

Copilot started work on behalf of Rello August 25, 2026 11:50 View session

Copilot finished work on behalf of Rello August 25, 2026 12:10

mgallien force-pushed the feature/newSearch branch from 5d490ea to ba58f8b Compare August 25, 2026 13:24

mgallien requested changes Aug 25, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Aug 27, 2026

View reviewed changes

Comment thread src/gui/search/unifiedsearchresultslistmodel.cpp Outdated

mgallien force-pushed the feature/newSearch branch from d4d8159 to f376c4e Compare August 28, 2026 10:54

mgallien approved these changes Aug 28, 2026

View reviewed changes

claucambra reviewed Aug 28, 2026

View reviewed changes

Comment thread src/gui/activity/qml/ActivityItem.qml Outdated

Comment thread src/gui/activity/qml/ActivityList.qml Outdated

claucambra requested changes Aug 28, 2026

View reviewed changes

Rello force-pushed the feature/newSearch branch 2 times, most recently from 8fbc4d6 to 717974c Compare August 29, 2026 10:46

chatgpt-codex-connector Bot reviewed Aug 29, 2026

View reviewed changes

Comment thread src/gui/search/unifiedsearchpeoplemodel.cpp Outdated

Comment thread src/gui/search/unifiedsearchresultslistmodel.cpp Outdated

Comment thread src/gui/search/UnifiedSearchResultDelegate.qml Outdated

claucambra requested changes Aug 31, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Sep 1, 2026

View reviewed changes

Comment thread src/gui/search/UnifiedSearchPeoplePopup.qml

chatgpt-codex-connector Bot reviewed Sep 1, 2026

View reviewed changes

Comment thread src/gui/search/unifiedsearchresultslistmodel.cpp

Comment thread src/gui/search/unifiedsearchresultslistmodel.cpp Outdated

claucambra requested changes Sep 2, 2026

View reviewed changes

CarlSchwan reviewed Sep 2, 2026

View reviewed changes

Rello and others added 4 commits September 2, 2026 10:48

fix(search): address unified search review feedback

997c81f

Signed-off-by: Rello <github@scherello.de> Assisted-by: Codex:GPT-5

fix(search): resolve CI failures

d34bef8

Import tray QML types explicitly and default-initialize search result value members. Signed-off-by: Rello <github@scherello.de> Assisted-by: Codex:GPT-5

fix(search): address remaining review feedback

a6b1a3c

Signed-off-by: Rello <github@scherello.de> Assisted-by: Codex:GPT-5

Rello force-pushed the feature/newSearch branch from 127f71f to a6b1a3c Compare September 2, 2026 08:48

fix(search): make people query restoration test deterministic

eee3b97

Signed-off-by: Rello <github@scherello.de> Assisted-by: Codex:GPT-5

claucambra approved these changes Sep 2, 2026

View reviewed changes

Uh oh!

Conversation

Rello commented Aug 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Rello commented Aug 21, 2026

Uh oh!

kra-mo left a comment

Choose a reason for hiding this comment

Uh oh!

kra-mo commented Aug 21, 2026

Uh oh!

Rello commented Aug 21, 2026

Uh oh!

kra-mo commented Aug 21, 2026

Uh oh!

Rello commented Aug 22, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

kra-mo left a comment

Choose a reason for hiding this comment

Uh oh!

Rello commented Aug 24, 2026

Uh oh!

kra-mo commented Aug 25, 2026

Uh oh!

Rello commented Aug 25, 2026

Uh oh!

kra-mo left a comment

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Rello commented Aug 25, 2026

Uh oh!

Copilot AI commented Aug 25, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

claucambra left a comment

Choose a reason for hiding this comment

Uh oh!

Rello commented Aug 21, 2026 •

edited

Loading