fix: warnings. - #10623
Open
camilasan wants to merge 4 commits into
Open
Conversation
camilasan
requested review from
claucambra,
i2h3,
mgallien and
nilsding
as code owners
August 18, 2026 14:51
Member
Author
|
/backport to stable-34.0 |
claucambra
reviewed
Aug 18, 2026
camilasan
force-pushed
the
bugfix/noid/warnings
branch
from
August 31, 2026 19:20
e000fa2 to
50cdb41
Compare
camilasan
force-pushed
the
bugfix/noid/warnings
branch
5 times, most recently
from
August 31, 2026 19:28
7c87ef6 to
5628b69
Compare
Cleans up compilation warnings: "warning: use of GNU ?: conditional expression extension, omitting middle operand [-Wgnu-conditional-omitted-operand]" Assisted-by: Claude Code:claude-sonnet-5 Signed-off-by: Camila Ayres <hello@camilasan.com>
The position parameter is only unused in the macOS branch, so scope the annotation there with Q_UNUSED instead of [[maybe_unused]] on the signature. Assisted-by: Claude Code:claude-opus-4-8 Signed-off-by: Camila Ayres <hello@camilasan.com>
LSSharedFileList was deprecated in macOS 10.11 with no public replacement for adding items to the Finder sidebar. Wrap the best-effort call in QT_WARNING_DISABLE_DEPRECATED to keep behavior and drop the 4 warnings. Assisted-by: Claude Code:claude-opus-4-8 Signed-off-by: Camila Ayres <hello@camilasan.com>
The logic was duplicated across the tray account popup files. Add a single helper in TrayPopupViewUtils. Assisted-by: Claude Code:claude-opus-4-8 Signed-off-by: Camila Ayres <hello@camilasan.com>
camilasan
force-pushed
the
bugfix/noid/warnings
branch
from
August 31, 2026 19:28
5628b69 to
f628071
Compare
|
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-10623.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
Cleans up warnings during compilation time.
Checklist
AI (if applicable)