Skip to content

fix(macOS): Verify ability to access Local Network - #10460

Merged
Rello merged 13 commits into
masterfrom
work/local-net-check-mac
Jul 29, 2026
Merged

fix(macOS): Verify ability to access Local Network#10460
Rello merged 13 commits into
masterfrom
work/local-net-check-mac

Conversation

@claucambra

Copy link
Copy Markdown
Collaborator

Resolves

#10452

Summary

On macOS 15+ it is possible for users to choose to disable access to the local network to the desktop client. This means if a user tries to connect to a server instance on the same network, the connection will fail if local network access is not granted.

As it stands, it is impossible for the code to differentiate between a "legitimate" connection failure and one caused by a connection denied by the system. This can make it confusing for users to understand why the application is failing to connect to an instance.

This PR adds a check for local network access permissions on macOS (and includes a polymorphic interface that can be used to implement a similar feature if/when Windows and Linux desktops choose to implement such an access restriction like macOS, iOS/iPadOS and Android have).

Screenshot 2026-07-27 at 17 53 44

/backport to stable-34.0 please

Checklist

AI (if applicable)

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
…uired from server

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
…b timeout

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
…count wizard

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
…ut happens in account wizard

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
…y casting

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Leave stubs for non-macOS platforms for now

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
…nd connection validator

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra claucambra added this to the 34.0.0 milestone Jul 27, 2026
@claucambra claucambra self-assigned this Jul 27, 2026
@claucambra claucambra added the os: 🍎 macOS Apple macOS, formerly also known as OS X label Jul 27, 2026
@claucambra

Copy link
Copy Markdown
Collaborator Author

/backport to stable-34.0 please

@mgallien mgallien modified the milestones: 34.0.0, 34.0.1 Jul 27, 2026
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
70.0% Coverage on New Code (required ≥ 80%)
E Maintainability Rating on New Code (required ≥ A)
128 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@github-actions

Copy link
Copy Markdown
Contributor

Artifact containing the AppImage: nextcloud-appimage-pr-10460.zip

Digest: sha256:9b6c22fbcf5df13969bd9322943235869e2cb655a807a69cb50fcdc7b4b08202

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@Rello

Rello commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

nice one!

@i2h3
i2h3 requested a review from Copilot July 28, 2026 10:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Rello
Rello merged commit 3af3b89 into master Jul 29, 2026
22 of 23 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feedback-requested os: 🍎 macOS Apple macOS, formerly also known as OS X

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants