fix(macOS): Verify ability to access Local Network - #10460
Conversation
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
…uired from server Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
…b timeout Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
…count wizard Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
…ut happens in account wizard Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
…y casting Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Leave stubs for non-macOS platforms for now Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
…nd connection validator Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
|
/backport to stable-34.0 please |
|
|
Artifact containing the AppImage: nextcloud-appimage-pr-10460.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
nice one! |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |




Resolves
#10452
Summary
On macOS 15+ it is possible for users to choose to disable access to the local network to the desktop client. This means if a user tries to connect to a server instance on the same network, the connection will fail if local network access is not granted.
As it stands, it is impossible for the code to differentiate between a "legitimate" connection failure and one caused by a connection denied by the system. This can make it confusing for users to understand why the application is failing to connect to an instance.
This PR adds a check for local network access permissions on macOS (and includes a polymorphic interface that can be used to implement a similar feature if/when Windows and Linux desktops choose to implement such an access restriction like macOS, iOS/iPadOS and Android have).
/backport to stable-34.0 please
Checklist
AI (if applicable)