fix(file-provider): Do not continue polling ETag from file provider when account is disabled - #10445
Conversation
claucambra
left a comment
claucambra
left a comment
There was a problem hiding this comment.
I would like to see a test for this too
i2h3
left a comment
i2h3
left a comment
There was a problem hiding this comment.
The wording is misleading because the file provider is not doing anything here. It is the main app which polls the server for new ETags for accounts set up with file providers. Only if the ETag changed, the file provider domain is signaled. So it is not like the file provider extension is not disrespecting something, it not even is involved. It is the main app which did not validate the precondition of an account being set up correctly before maybe (only on happy path) triggering the file provider domain to synchronize.
i2h3
changed the title
github-project-automation
Bot
moved this to 🧭 Planning evaluation (don't pick)
in 💻 Desktop Clients team
i2h3
added
bug
os: 🍎 macOS
i2h3
moved this from 🧭 Planning evaluation (don't pick)
to 🏗️ In progress
in 💻 Desktop Clients team
|
@claucambra test was added to test this new status check. expected like that? |
please provide a more descriptive commit message, it will otherwise be impossible to tell from the commit log what this commit does |
Rello
changed the title
…ount is not connected This change will align it to the classic sync Assisted-by: GPT-5.6 Signed-off-by: Rello <github@scherello.de>
…ns do not trigger polling ETag check Assisted-by: GPT-5.6 Signed-off-by: Rello <github@scherello.de>
d0fe646 to
ddfa202
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-10445.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
claucambra
changed the title
github-project-automation
Bot
moved this from 🏗️ In progress
to ☑️ Done
in 💻 Desktop Clients team
|
/backport to stable-34.0 please |
|
3 participants
the apple file provider extension is not respecting an 401 from the server (token revoked) and is still sending propfinds every 30 seconds.
This change will align it to the classic sync
Assisted-by: GPT-5.6