feat(Assistant): implement full Assistant features also on client by Rello · Pull Request #10345 · nextcloud/desktop

Rello · 2026-07-10T08:46:08Z

cover all server Assistant feature
continue conversations on server/client
isolated assistant dialog for better modularisation of the client

Rello · 2026-07-10T08:46:30Z

@kra-mo @jancborchardt

kra-mo · 2026-08-14T12:52:22Z

The Assistant on the web will likely be redesigned next cycle, so I'd maybe hold off on iterating on the UI for now.

Rello · 2026-08-21T06:36:31Z

The Assistant on the web will likely be redesigned next cycle, so I'd maybe hold off on iterating on the UI for now.

Hello,
next cycle you mean 36?
the current one is pretty useless so I would like to get at least the current approach in.
For simplicity I would suggests that we hide all buttons on the top and only default it to the "chat". because this feature will then sync with the conversations on the server.
the current implementation is pure temporary and super alpha. the proper chat-only implementation would make it actually very usable already

Rello · 2026-08-21T06:37:32Z

@copilot resolve the merge conflicts in this pull request

Rello · 2026-08-21T06:40:28Z

Reload icon we can remove I would say. its there to reload the conversations from the server. it is reloaded during the window startup. its not very likely that there are new conversations for the same user when they are currently in this dialog. less distraction.
new chat needs to move next to the conversation dropdown

Copilot · 2026-08-21T06:42:27Z

@copilot resolve the merge conflicts in this pull request

Merge conflicts with origin/master have been resolved in commit a4d01ff. The resolution keeps both the unified search UI (from this PR) and the assistant panel features, while adopting master's updated file paths (src/gui/activity/qml/ActivitiesWindow.qml, src/gui/search/unifiedsearchresultslistmodel.h).

kra-mo · 2026-08-21T10:53:22Z

Hello,
next cycle you mean 36?

Yes.

For simplicity I would suggests that we hide all buttons on the top and only default it to the "chat". because this feature will then sync with the conversations on the server.

That's fine by me.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 97e91ad54d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Move Assistant operations into a dedicated controller and expose task and chat workflows in a separate window. Signed-off-by: Rello <Rello@users.noreply.github.com> Signed-off-by: Rello <github@scherello.de> Assisted-by: Codex:GPT-5

Remove the legacy tray implementation, encapsulate Assistant resources and networking, reject stale asynchronous replies, and bound chat polling. Signed-off-by: Rello <github@scherello.de> Assisted-by: Codex:GPT-5

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c66f53a706

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Signed-off-by: Rello <github@scherello.de> Assisted-by: Codex:GPT-5

github-actions · 2026-08-24T05:42:12Z

Artifact containing the AppImage: nextcloud-appimage-pr-10345.zip

Digest: sha256:90c2ee18ffb51c2776bed2fe30c7c5e87929a148ede2aba92843599e16a9119f

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

kra-mo

An improvement

Rello · 2026-08-28T09:18:38Z

@copilot resolve the merge conflicts in this pull request

Keep assistant module in src/gui/assistant/ with requestGeneration API. Remove assistant methods from usermodel.cpp (moved to assistant module). Remove src/libsync/ocsassistantconnector.cpp (moved to src/gui/assistant/). Assisted-by: ClaudeCode:claude-sonnet-4-5 Co-authored-by: Rello <13385119+Rello@users.noreply.github.com>

Copilot · 2026-08-28T09:25:39Z

@copilot resolve the merge conflicts in this pull request

Merge conflicts with origin/master have been resolved in commit 4d2f519. Key resolutions:

Kept the requestGeneration API in src/gui/assistant/ocsassistantconnector.h
Removed the assistant methods that master added back to usermodel.cpp (they live in the assistant module now)
Deleted src/libsync/ocsassistantconnector.cpp (superseded by src/gui/assistant/ocsassistantconnector.cpp)

claucambra · 2026-09-01T10:58:42Z

Also seems like this doesn't build correctly @Rello maybe worth checking the agent product?

Split large QML components, centralize UI measurements, align QML registration and Qt keyword usage, and cover chat status handling. Signed-off-by: Rello <github@scherello.de> Assisted-by: Codex:GPT-5

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8ec87677a6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-09-01T12:55:14Z

+        requestFailed(QStringLiteral("chatConversations"), statusCode);
+        return;
+    }
+    _chatConversations.replaceFromResponse(json, _selectedChatConversationId);


Unwrap OCS data before parsing chat responses

All added chat requests target /ocs/v2.php, and JsonApiJob delivers the complete OCS document, but this passes that object directly to AssistantConversationModel::replaceFromResponse(), which reads only json.array(). A normal { "ocs": { "data": [...] } } response therefore produces an empty conversation list; the create-message, generation, and session handlers make the same top-level assumption and consequently fail to find IDs or messages. Unwrap ocs.data consistently and cover these workflows with realistically enveloped responses.

AGENTS.md reference: AGENTS.md:L33-L36

Useful? React with 👍 / 👎.

sonarqubecloud · 2026-09-01T13:40:05Z

Quality Gate failed

Failed conditions
20.4% Coverage on New Code (required ≥ 80%)
257 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

claucambra

Some small changes and one bigger one. I think the test suite is insufficient for the breadth of additions being made here

claucambra · 2026-09-03T09:00:22Z

+    void slotChatSessionChecked(quint64 requestGeneration, const QJsonDocument &json, int statusCode);
+
+private:
+    [[nodiscard]] quint64 beginRequest();


Could we not just remove the [[nodiscard]] rather than casting to void wherever we don't need the result?

claucambra · 2026-09-03T09:02:02Z

+        return true;
+    }();
+    Q_UNUSED(initialized)
+}


What is the point of returning a value here?

claucambra · 2026-09-03T09:05:11Z

+static void initializeAssistantResources()
+{
+    Q_INIT_RESOURCE(assistant);
+}


I'm not sure why we need this to be its own function? can't we just use it in the lambda below?

claucambra · 2026-09-03T09:06:15Z

+    void dateTextDoesNotGuessTimestampUnit()
+    {
+        constexpr auto timestamp = 1000000000001LL;
+        const auto expected = QLocale::system().toString(QDateTime::fromSecsSinceEpoch(timestamp), QLocale::ShortFormat);
+
+        QCOMPARE(AssistantUtils::dateText(timestamp), expected);
+    }


This test does not in actuality test anything useful; it's verifying a past implementation detail. Should be removed

claucambra · 2026-09-03T09:07:00Z

+
+}
+
+class TestAssistantController : public QObject


This test suite seems to be really limited compared to all the new additions

Rello added the design Design, UI, UX, etc. label Jul 10, 2026

Rello added this to the 34.0.1 milestone Jul 10, 2026

Rello changed the title ~~feat: implement full Assistant features also on client~~ draft: implement full Assistant features also on client Jul 10, 2026

Rello modified the milestones: 34.0.1, 34.0.2 Jul 30, 2026

Rello modified the milestones: 34.0.2, 35.0.0 Aug 11, 2026

Copilot started work on behalf of Rello August 21, 2026 06:37 View session

Copilot finished work on behalf of Rello August 21, 2026 06:43

Rello moved this to NC35 in 💻 Desktop Clients team Aug 21, 2026

Rello added this to 💻 Desktop Clients team Aug 21, 2026

Rello marked this pull request as ready for review August 22, 2026 21:50

Rello requested review from camilasan, claucambra, i2h3, mgallien and nilsding as code owners August 22, 2026 21:50

chatgpt-codex-connector Bot reviewed Aug 22, 2026

View reviewed changes

Comment thread src/gui/tray/MainWindow.qml

Comment thread src/gui/assistant/qml/AssistantWindow.qml Outdated

Comment thread src/gui/assistant/assistantcontroller.cpp Outdated

Comment thread src/gui/assistant/assistantcontroller.cpp Outdated

feat(assistant): add desktop assistant interface

26cdfe0

Move Assistant operations into a dedicated controller and expose task and chat workflows in a separate window. Signed-off-by: Rello <Rello@users.noreply.github.com> Signed-off-by: Rello <github@scherello.de> Assisted-by: Codex:GPT-5

Rello force-pushed the feature/newAssistant branch from 97e91ad to 26cdfe0 Compare August 23, 2026 06:28

fix(assistant): isolate module and harden request lifecycle

c66f53a

Remove the legacy tray implementation, encapsulate Assistant resources and networking, reject stale asynchronous replies, and bound chat polling. Signed-off-by: Rello <github@scherello.de> Assisted-by: Codex:GPT-5

chatgpt-codex-connector Bot reviewed Aug 23, 2026

View reviewed changes

Comment thread src/gui/tray/MainWindow.qml

Comment thread src/gui/assistant/assistanttasktypemodel.cpp

fix(test): implement test feedback

0279ae1

Signed-off-by: Rello <github@scherello.de> Assisted-by: Codex:GPT-5

kra-mo approved these changes Aug 24, 2026

View reviewed changes

Rello changed the title ~~draft: implement full Assistant features also on client~~ feat(Assistant): implement full Assistant features also on client Aug 28, 2026

Copilot started work on behalf of Rello August 28, 2026 09:18 View session

Rello self-assigned this Aug 28, 2026

Copilot finished work on behalf of Rello August 28, 2026 09:26

claucambra requested changes Sep 1, 2026

View reviewed changes

fix(assistant): address review feedback

8ec8767

Split large QML components, centralize UI measurements, align QML registration and Qt keyword usage, and cover chat status handling. Signed-off-by: Rello <github@scherello.de> Assisted-by: Codex:GPT-5

chatgpt-codex-connector Bot reviewed Sep 1, 2026

View reviewed changes

claucambra requested changes Sep 3, 2026

View reviewed changes

Uh oh!

Conversation

Rello commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Rello commented Jul 10, 2026

Uh oh!

kra-mo commented Aug 14, 2026

Uh oh!

Rello commented Aug 21, 2026

Uh oh!

Rello commented Aug 21, 2026

Uh oh!

Rello commented Aug 21, 2026

Uh oh!

Copilot AI commented Aug 21, 2026

Uh oh!

kra-mo commented Aug 21, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Aug 24, 2026

Uh oh!

kra-mo left a comment

Choose a reason for hiding this comment

Uh oh!

Rello commented Aug 28, 2026

Uh oh!

Copilot AI commented Aug 28, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

claucambra commented Sep 1, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Sep 1, 2026

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Sep 1, 2026

Quality Gate failed

Uh oh!

claucambra left a comment

Choose a reason for hiding this comment

Uh oh!

claucambra Sep 3, 2026

Choose a reason for hiding this comment

Uh oh!

claucambra Sep 3, 2026

Choose a reason for hiding this comment

Uh oh!

claucambra Sep 3, 2026

Choose a reason for hiding this comment

Uh oh!

claucambra Sep 3, 2026

Choose a reason for hiding this comment

Uh oh!

claucambra Sep 3, 2026

Rello commented Jul 10, 2026 •

edited

Loading