Feature/governance labels integration#10100
Draft
mgallien wants to merge 8 commits into
Draft
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| void setCustomEntityType(const QString &newCustomEntityType); | ||
|
|
||
| QString entityId() const; |
Contributor
There was a problem hiding this comment.
function entityId should be marked [[nodiscard]]
Suggested change
| QString entityId() const; | |
| [[nodiscard]] QString entityId() const; |
mgallien
force-pushed
the
feature/governanceLabelsIntegration
branch
from
08ca064 to
1582c09
Compare
github-actions
Bot
dismissed
their stale review
No Clang-Tidy warnings found so I assume my comments were addressed
mgallien
force-pushed
the
feature/governanceLabelsIntegration
branch
3 times, most recently
from
b830eeb to
67ce384
Compare
mgallien
force-pushed
the
feature/governanceLabelsIntegration
branch
2 times, most recently
from
9eb43f4 to
53e3bf8
Compare
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-10100.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
will enable to share type definitions in all real jobs Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
also improve the available properties for the job parameters Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
finish implementing most of the code needed to send requests to the governance API will need further work to see how to read the replies and make something usefull Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
should enable us to test the requests one by one and ensure we decode properly the replies Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
mgallien
force-pushed
the
feature/governanceLabelsIntegration
branch
from
53e3bf8 to
13b835a
Compare
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
mgallien
force-pushed
the
feature/governanceLabelsIntegration
branch
from
13b835a to
8237272
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for opening a pull request on the Nextcloud desktop client.
Before sending a pull request that fixes a security issue please report it via our HackerOne page (https://hackerone.com/nextcloud) following our security policy (https://nextcloud.com/security/).
This allows us to coordinate the fix and release without potentially exposing all Nextcloud client users in the meantime.
Instead of a Contributor License Agreement (CLA) we use a Developer Certificate of Origin (DCO).
https://en.wikipedia.org/wiki/Developer_Certificate_of_Origin
-->
Resolves
#
Close https://github.com/nextcloud-gmbh/server/issues/953
Close https://github.com/nextcloud-gmbh/server/issues/957
Summary
TODO
Checklist
AI (if applicable)