Revert(create): restore explicit insertAtPosition opt-in

Inferring the reorder-on-insert behavior from `$order !== 999` broke
cloneCard() and DefaultBoardService, which call create() with real,
already-correct order values (e.g. 0) that must not trigger a shift of
other cards in the stack. Restore the explicit $insertAtPosition flag,
opted into only by the OCS controller used by the new add-card UI.

Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>

Author: theoholl

lib/Controller/CardOcsController.php

@@ -48,7 +48,7 @@ public function create(string $title, int $stackId, ?int $boardId = null, ?strin
 		if (!$owner) {
 			$owner = $this->userId;
 		}
-		$card = $this->cardService->create($title, $stackId, $type, $order, $owner, $description, $duedate, $startdate, $color);
+		$card = $this->cardService->create($title, $stackId, $type, $order, $owner, $description, $duedate, $startdate, $color, insertAtPosition: $order !== 999);
 
 		// foreach ($labels as $label) {
 		// 	$this->assignLabel($card->getId(), $label);

lib/Service/CardService.php

@@ -189,7 +189,7 @@ public function findCalendarEntries(int $boardId): array {
 	 * @throws \OCP\AppFramework\Db\MultipleObjectsReturnedException
 	 * @throws BadrequestException
 	 */
-	public function create(string $title, int $stackId, string $type, int $order, string $owner, string $description = '', $duedate = null, $startdate = null, ?string $color = null): Card {
+	public function create(string $title, int $stackId, string $type, int $order, string $owner, string $description = '', $duedate = null, $startdate = null, ?string $color = null, bool $insertAtPosition = false): Card {
 		$this->cardServiceValidator->check(compact('title', 'stackId', 'type', 'order', 'owner'));
 
 		$this->permissionService->checkPermission($this->stackMapper, $stackId, Acl::PERMISSION_EDIT);
@@ -207,8 +207,7 @@ public function create(string $title, int $stackId, string $type, int $order, st
 		$card->setStartdate($startdate);
 		$card->setColor($color);
 
-		if ($order === 999) {
-			// Append to the end of the stack
+		if (!$insertAtPosition) {
 			$card = $this->cardMapper->insert($card);
 		} else {
 			// Insert at the requested position and shift the surrounding cards

tests/unit/Service/CardServiceTest.php

@@ -284,7 +284,7 @@ public function testCreateAtTopReordersCardsInTransaction(): void {
 			->with(123)
 			->willReturn($stack);
 
-		$createdCard = $this->cardService->create('New card', 123, 'plain', 0, 'admin');
+		$createdCard = $this->cardService->create('New card', 123, 'plain', 0, 'admin', insertAtPosition: true);
 
 		$this->assertSame(0, $createdCard->getOrder());
 		$this->assertSame(1, $firstCard->getOrder());
@@ -313,7 +313,7 @@ public function testCreateAtTopRollsBackWhenReorderingFails(): void {
 			->willThrowException(new \RuntimeException('Could not reorder cards'));
 
 		$this->expectException(\RuntimeException::class);
-		$this->cardService->create('New card', 123, 'plain', 0, 'admin');
+		$this->cardService->create('New card', 123, 'plain', 0, 'admin', insertAtPosition: true);
 	}
 
 	public function testClone() {