fix(create): centralize insert-at-position handling and close add-card form after creation

- Let CardService::create() decide when to reorder based on the requested
  order, so all card creation endpoints behave consistently.
- Close the inline add-card form after a card is successfully created to
  prevent it from covering the new card and fix flaky Cypress tests.

Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>

Author: theoholl

cypress/e2e/cardFeatures.js

@@ -110,7 +110,6 @@ describe('Card', function () {
 					cy.get('.stack__card-add input[type="text"]').type(title)
 					cy.get('.stack__card-add input[type="submit"]').click()
 					cy.wait('@createCard')
-					cy.get('.stack__card-add input[type="text"]').type('{esc}')
 				})
 			}
 
@@ -380,13 +379,6 @@ describe('Card', function () {
 			cy.get('.stack__card-add form input[type=submit]')
 				.first().click()
 			cy.get(`.card:contains("${newCardTitle}")`).should('be.visible').click()
-			cy.get('body').then(($body) => {
-				const addCardInput = $body.find('.stack__card-add form input#new-stack-input-main')
-				if (addCardInput.length) {
-					cy.wrap(addCardInput.first()).type('{esc}')
-				}
-			})
-			cy.get('.stack__card-add form').should('not.exist')
 
 			// Add delay to ensure the events are bound
 			cy.wait(1000)

lib/Controller/CardOcsController.php

@@ -48,7 +48,7 @@ public function create(string $title, int $stackId, ?int $boardId = null, ?strin
 		if (!$owner) {
 			$owner = $this->userId;
 		}
-		$card = $this->cardService->create($title, $stackId, $type, $order, $owner, $description, $duedate, $startdate, $color, insertAtPosition: $order !== 999);
+		$card = $this->cardService->create($title, $stackId, $type, $order, $owner, $description, $duedate, $startdate, $color);
 
 		// foreach ($labels as $label) {
 		// 	$this->assignLabel($card->getId(), $label);

lib/Service/CardService.php

@@ -189,7 +189,7 @@ public function findCalendarEntries(int $boardId): array {
 	 * @throws \OCP\AppFramework\Db\MultipleObjectsReturnedException
 	 * @throws BadrequestException
 	 */
-	public function create(string $title, int $stackId, string $type, int $order, string $owner, string $description = '', $duedate = null, $startdate = null, ?string $color = null, bool $insertAtPosition = false): Card {
+	public function create(string $title, int $stackId, string $type, int $order, string $owner, string $description = '', $duedate = null, $startdate = null, ?string $color = null): Card {
 		$this->cardServiceValidator->check(compact('title', 'stackId', 'type', 'order', 'owner'));
 
 		$this->permissionService->checkPermission($this->stackMapper, $stackId, Acl::PERMISSION_EDIT);
@@ -207,9 +207,11 @@ public function create(string $title, int $stackId, string $type, int $order, st
 		$card->setStartdate($startdate);
 		$card->setColor($color);
 
-		if (!$insertAtPosition) {
+		if ($order === 999) {
+			// Append to the end of the stack
 			$card = $this->cardMapper->insert($card);
 		} else {
+			// Insert at the requested position and shift the surrounding cards
 			$this->connection->beginTransaction();
 			try {
 				$card = $this->cardMapper->insert($card);

src/components/board/StackCardAdd.vue

@@ -108,6 +108,7 @@ export default {
 					...(this.addAtTop ? { order: 0 } : {}),
 				})
 				this.title = ''
+				this.visible = false
 				this.$emit('created', newCard)
 				if (!this.cardDetailsInModal) {
 					this.$router.push({ name: 'card', params: { cardId: newCard.id } })

tests/unit/Service/CardServiceTest.php

@@ -284,7 +284,7 @@ public function testCreateAtTopReordersCardsInTransaction(): void {
 			->with(123)
 			->willReturn($stack);
 
-		$createdCard = $this->cardService->create('New card', 123, 'plain', 0, 'admin', insertAtPosition: true);
+		$createdCard = $this->cardService->create('New card', 123, 'plain', 0, 'admin');
 
 		$this->assertSame(0, $createdCard->getOrder());
 		$this->assertSame(1, $firstCard->getOrder());
@@ -313,7 +313,7 @@ public function testCreateAtTopRollsBackWhenReorderingFails(): void {
 			->willThrowException(new \RuntimeException('Could not reorder cards'));
 
 		$this->expectException(\RuntimeException::class);
-		$this->cardService->create('New card', 123, 'plain', 0, 'admin', insertAtPosition: true);
+		$this->cardService->create('New card', 123, 'plain', 0, 'admin');
 	}
 
 	public function testClone() {