fix(test): adjust tests and add phpunit workflow - #275
Merged
Conversation
Signed-off-by: kyteinsky <kyteinsky@gmail.com> Assisted-by: Github Copilot:claude-opus-5
Signed-off-by: kyteinsky <kyteinsky@gmail.com>
kyteinsky
force-pushed
the
fix/test-runner-workflow
branch
from
September 1, 2026 03:43
05f166d to
08c5041
Compare
The phpunit workflow failed on Nextcloud 36 with PHP >= 8.4: TypeError: OC\Files\Config\UserMountCache::__construct(): Argument #1 ($connection) must be of type OCP\IDBConnection, null given - Extend PHPUnit\Framework\TestCase instead of Test\TestCase. - Add the DB group, since the test uses the real IJobList, and declare it with the #[Group] attribute. ref: nextcloud/server#52538 Signed-off-by: kyteinsky <kyteinsky@gmail.com> Assisted-by: Github Copilot:claude-opus-5
kyteinsky
force-pushed
the
fix/test-runner-workflow
branch
from
September 1, 2026 04:47
d6f46d7 to
199f34c
Compare
Signed-off-by: kyteinsky <kyteinsky@gmail.com> Assisted-by: Github Copilot:claude-opus-5
marcelklehr
approved these changes
Sep 2, 2026
kyteinsky
enabled auto-merge
September 2, 2026 11:10
kyteinsky
disabled auto-merge
September 2, 2026 11:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also add NC 36 support
🤖 AI (if applicable)