fix: use 2 percent index completion threshold - #177
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the initial index completion logic to use a 2% threshold instead of requiring zero queued files. Instead of waiting for all files to be indexed, the system now considers initial indexing complete when queued new files are less than 2% of total eligible files.
- Changed completion threshold from 0 queued files to 2% of total eligible files
- Added calculation of eligible files count and threshold comparison
- Updated error logging to include both queued files and total eligible files counting failures
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/Service/StorageService.php | Removed unused import and updated exception documentation |
| lib/BackgroundJobs/IndexerJob.php | Implemented 2% threshold logic for index completion determination |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
kyteinsky
force-pushed
the
initial-index-threshold
branch
from
September 22, 2025 09:37
5f6dd41 to
0f1340f
Compare
marcelklehr
reviewed
Sep 22, 2025
marcelklehr
approved these changes
Sep 22, 2025
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.