Skip to content

fix: Use MissingIndicesEvent instead of migration - #166

Merged
marcelklehr merged 1 commit into
mainfrom
fix/missing-index
Aug 28, 2025
Merged

fix: Use MissingIndicesEvent instead of migration#166
marcelklehr merged 1 commit into
mainfrom
fix/missing-index

Conversation

@marcelklehr

Copy link
Copy Markdown
Member

No description provided.

@marcelklehr
marcelklehr requested a review from kyteinsky August 28, 2025 07:50

@kyteinsky kyteinsky left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@marcelklehr
marcelklehr enabled auto-merge August 28, 2025 07:54
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
marcelklehr merged commit 13e814d into main Aug 28, 2025
33 of 34 checks passed
@marcelklehr
marcelklehr deleted the fix/missing-index branch August 28, 2025 09:15
@ChristophWurst

Copy link
Copy Markdown
Member

@marcelklehr the index will be missing for new installations until the admin notices the missing index warning and applies it manually.

Therefore it's recommended to edit the original migration adding the table to already apply the index. That would be lib/Migration/Version004004000Date20250523135634.php in this case. Leave a comment to make it obvious that the migration was changed, like you can see here: https://github.com/nextcloud/server/blob/2f2049cbeb7ee51204ebe6610a29663281a62d49/core/Migrations/Version13000Date20170718121200.php#L735-L738

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants