fix: addressbook checkbox - #5688
Merged
Merged
Conversation
Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Grigory Vodyanov <scratchx@gmx.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
GVodyanov
added
3. to review
GVodyanov
marked this pull request as ready for review
August 30, 2026 10:22
GVodyanov
requested review from
SebastianKrupinski and
hamza221
as code owners
August 30, 2026 10:22
odzhychko
reviewed
Sep 3, 2026
odzhychko
requested changes
Sep 3, 2026
Contributor
Author
|
Note: this only happens for addressbooks that were just created, forgot to mention |
odzhychko
reviewed
Sep 3, 2026
| renameAddressbook(context, { addressbook, newName }) { | ||
| addressbook = state.addressbooks.find((search) => search.id === addressbook.id) | ||
| addressbook.displayName = newName | ||
| renameAddressbook(state, { addressbook, newName }) { |
odzhychko
approved these changes
Sep 3, 2026
odzhychko
left a comment
odzhychko
left a comment
There was a problem hiding this comment.
Note: this only happens for addressbooks that were just created, forgot to mention
Could reproduce now and the fix works.
Contributor
Author
|
/backport to stable8.8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes this:
Screencast.From.2026-08-30.12-19-13.mp4
🤖 AI (if applicable)