Skip to content

chore: removing unused properties about org chart - #5646

Merged
hamza221 merged 1 commit into
nextcloud:mainfrom
madbob:org_minor_fixes
Sep 7, 2026
Merged

chore: removing unused properties about org chart#5646
hamza221 merged 1 commit into
nextcloud:mainfrom
madbob:org_minor_fixes

Conversation

@madbob

@madbob madbob commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Some minor changes related to the Org Chart:

  • fixed the missing reference to logger (recently introduced in chore(lint): dont allow console calls #5624)
  • removed unused properties introduced in Add organization charts #2954. It seems the intention was to bubble the full list of contacts from ContactsContent to ContactDetailsProperty probably to permit cross-contacts references, then the otherContacts mixin's function has been used to draw directly from $store.getters.getSortedContacts (this is my own speculation!). I've tested the Chart panel and it works also without those properties (apart for Adding line manager property does not work #4454, which has already been fixed but not yet merged in main)

@codecov

codecov Bot commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/components/AppContent/ContactsContent.vue 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Signed-off-by: Roberto Guido <info@madbob.org>
@hamza221
hamza221 enabled auto-merge September 7, 2026 13:29
@hamza221
hamza221 merged commit b16c8a7 into nextcloud:main Sep 7, 2026
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants