fix(teams): allow hiding the shared folder button via app config

[lennart441]

Summary

Resolves: #5638

occ config:app:set contacts hide_team_shared_folder_creation --value=true

Default (show create button)

Now optional (no create button)

It is still possible to share a personal folder with a team.

AI

• Partly generated using Cursor Grok 4.6

[codecov]

Codecov Report

❌ Patch coverage is 30.76923% with 9 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
lib/ConfigLexicon.php	0.00%	7 Missing ⚠️
src/components/CircleDetails.vue	0.00%	1 Missing ⚠️
src/services/hideTeamSharedFolderCreation.js	0.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[artonge]

I think we need to target stable8.8 now.

[hamza221]

It should target main then we can backport it.
Teams ui Is back to contacts #5669 but gated for Nextcloud versions <=34

[hamza221]

Blocking accidental merge

[lennart441]

@artonge @hamza221 changes done, please rereview

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: f2da788b-7b6d-42c8-bfd2-bef3107bcee1

📥 Commits

Reviewing files that changed from the base of the PR and between 7c8d8b3 and 924af4a.

📒 Files selected for processing (5)

• lib/ConfigLexicon.php
• lib/Controller/PageController.php
• src/components/CircleDetails.vue
• src/services/hideTeamSharedFolderCreation.js
• tests/unit/Controller/PageControllerTest.php

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

---

📝 Walkthrough

Walkthrough

The change adds the HIDE_TEAM_SHARED_FOLDER_CREATION boolean configuration. PageController reads the value and exposes it through frontend initial state. A frontend service loads the value. CircleDetails hides the folder creation shortcut when configured and hides the resource shortcuts when no resource types are enabled. Unit tests cover enabled and default-false configuration values.

Merge Risk: ⚪ Minimal · up to 924af

This change adds an optional setting to hide the shared-folder creation button while preserving the current default behavior and existing sharing capabilities. No actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 10.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 10 functions across 4 files. (1 skipped: …	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the Teams change and the new app-config option to hide the shared-folder button.
Description check	✅ Passed	The description explains the configuration command, default behavior, hidden-button behavior, and retained personal-folder sharing.
Linked Issues check	✅ Passed	The changes implement issue #5638 by adding an app configuration key, exposing its value to the frontend, and hiding the team shared-folder creation button when enabled. The default remains unchanged.
Out of Scope Changes check	✅ Passed	The configuration, frontend state handling, UI condition, and unit tests are directly related to issue #5638. No unrelated code changes are identified.

Full details: Docstring Coverage

Explanation

Docstring coverage is 10.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 10 functions across 4 files. (1 skipped: 1 unsupported.)

• Fix all pre-merge checks with AI

Warning

Some tools did not complete. Review the errors below.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/components/CircleDetails.vue

ESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox.

src/services/hideTeamSharedFolderCreation.js

ESLint skipped: the matched ESLint configuration already failed (missing-dependency).

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[hamza221]

/backport to stable8.8

[hamza221]

Could you squash your commits then we can merge