fix: Sort by "last modified" (issue #5158) by v3DJG6GL · Pull Request #5265 · nextcloud/contacts

v3DJG6GL · 2026-04-20T18:19:48Z

Summary

With sort order set to Last modified:

Switching between groups (e.g. All contacts ↔ Not grouped) showed an error:

Unable to retrieve the contact from the server, please check your network connection.

After reloading the page, the sort setting was reset to the previous value.
This issue was described in Bug: Sort by "last modified" is not working #5158

Underlying issue: sorting crashed whenever any contact had a missing or malformed REV (last-modified) value:
The code called a date method on every contact's REV. If REV was missing or not a valid date, it threw an error.

Changes

Read each contact's REV once when contacts are first loaded from the server, and store a plain timestamp (or null if it's missing/unreadable).
Contacts with no valid REV sort to the end instead of crashing the list.
Tolerate malformed date strings (e.g. wrong format, missing seconds) by parsing them defensively.
Make the rev getter return null on error instead of throwing, so one contact with a broken REV can't crash the component that reads it.
Stop fabricating REV = now when one is missing (both in the Contact constructor and in a background auto-"fix"). The old behavior made contacts jump to the top every time they were touched.
Don't re-sort the whole list when a contact is opened. Its stored REV doesn't change just because it was viewed.
Replaced custom scroll math with the list library's built-in scroll-into-view, which prevents visible jumps when the list updates.

LLM Disclosure

Developed with assistance from Claude Code (Opus 4.7, 1M context).
The LLM helped me identify the related files, code parts and proposed possible code modifications and fixes.
I've manually reviewed, the code the best I could.
A proper code review is required in any case...

…ast-modified sorting Signed-off-by: v3DJG6GL <72495210+v3DJG6GL@users.noreply.github.com>

…imitives at storage time Signed-off-by: v3DJG6GL <72495210+v3DJG6GL@users.noreply.github.com>

Signed-off-by: v3DJG6GL <72495210+v3DJG6GL@users.noreply.github.com>

…change detection Signed-off-by: v3DJG6GL <72495210+v3DJG6GL@users.noreply.github.com>

…ore primitives Signed-off-by: v3DJG6GL <72495210+v3DJG6GL@users.noreply.github.com>

…o prevent fake timestamps Signed-off-by: v3DJG6GL <72495210+v3DJG6GL@users.noreply.github.com>

…q, curly braces) Signed-off-by: v3DJG6GL <72495210+v3DJG6GL@users.noreply.github.com>

…le malformed dates Signed-off-by: v3DJG6GL <72495210+v3DJG6GL@users.noreply.github.com>

…ed dates Signed-off-by: v3DJG6GL <72495210+v3DJG6GL@users.noreply.github.com>

…rmalization Signed-off-by: v3DJG6GL <72495210+v3DJG6GL@users.noreply.github.com>

Signed-off-by: v3DJG6GL <72495210+v3DJG6GL@users.noreply.github.com>

…act, skipSort?} Signed-off-by: v3DJG6GL <72495210+v3DJG6GL@users.noreply.github.com>

Signed-off-by: v3DJG6GL <72495210+v3DJG6GL@users.noreply.github.com>

codecov · 2026-04-20T22:34:15Z

Codecov Report

❌ Patch coverage is 27.45098% with 37 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/store/contacts.js	0.00%	23 Missing and 14 partials ⚠️

📢 Thoughts on this report? Let us know!

github-actions · 2026-05-05T02:16:01Z

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

…dified-5158

v3DJG6GL · 2026-07-04T15:46:11Z

@GVodyanov could you take a look at this PR please? I don't want to and don't have the capacity to keep this PR up-to-date over months...
Thanks!

hamza221

Thank you for the PR, The fix looks really promising

hamza221 · 2026-07-07T18:01:13Z

Could you also follow our AI-policy for commit messages https://github.com/nextcloud/contacts/blob/main/AGENTS.md#commit-message-format .
And squash your commits into one => this could be done at the end before merge.

- rebuild REV into extended ISO 8601 with a single normalization instead of chained regex replacements - document the ical.js fixed-position reformatting quirk that produces misplaced separators on REV values missing seconds - cover all supported REV formats with unit tests Assisted-by: Claude:claude-fable-5 Signed-off-by: v3DJG6GL <72495210+v3DJG6GL@users.noreply.github.com>

- split the zone suffix off the REV value before stripping separators so the minus of a negative UTC offset is no longer removed, which made parsing fail and the contact sort as if it had no REV - add unit tests for negative offsets in basic and extended format Assisted-by: Claude:claude-fable-5 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: v3DJG6GL <72495210+v3DJG6GL@users.noreply.github.com>

hamza221 · 2026-08-07T12:49:10Z

Needs conflict resolution

…dified-5158 # Conflicts: # src/components/ContactsList.vue # src/models/contact.js # src/services/checks/invalidREV.js # src/store/contacts.js

v3DJG6GL · 2026-08-07T13:47:31Z

Needs conflict resolution

conflicts resolved :)

v3DJG6GL requested review from GVodyanov and hamza221 as code owners April 20, 2026 18:19

v3DJG6GL added 20 commits April 20, 2026 20:59

fix(contacts): include REV in MinimalContactProperties for accurate l…

f0ed0c4

…ast-modified sorting Signed-off-by: v3DJG6GL <72495210+v3DJG6GL@users.noreply.github.com>

fix(contacts): add extractSortValue helper to convert ICAL.Time to pr…

993fb84

…imitives at storage time Signed-off-by: v3DJG6GL <72495210+v3DJG6GL@users.noreply.github.com>

fix(contacts): rewrite sortData to compare primitives with null-safety

feff36f

Signed-off-by: v3DJG6GL <72495210+v3DJG6GL@users.noreply.github.com>

fix(contacts): use extractSortValue in addContact to store primitives

8c42520

Signed-off-by: v3DJG6GL <72495210+v3DJG6GL@users.noreply.github.com>

fix(contacts): use extractSortValue in sortContacts to store primitives

4a5c22e

Signed-off-by: v3DJG6GL <72495210+v3DJG6GL@users.noreply.github.com>

fix(contacts): use extractSortValue in updateContact with simplified …

8d5ba78

…change detection Signed-off-by: v3DJG6GL <72495210+v3DJG6GL@users.noreply.github.com>

fix(contacts): use extractSortValue in updateContactAddressbook to st…

06244a9

…ore primitives Signed-off-by: v3DJG6GL <72495210+v3DJG6GL@users.noreply.github.com>

fix(contacts): inject existing REV into vCard string before parsing t…

3f3a951

…o prevent fake timestamps Signed-off-by: v3DJG6GL <72495210+v3DJG6GL@users.noreply.github.com>

fix(contacts): fix lint errors in contacts store (import order, eqeqe…

457e7a8

…q, curly braces) Signed-off-by: v3DJG6GL <72495210+v3DJG6GL@users.noreply.github.com>

fix(contacts): bypass ical.js REV parsing in extractSortValue to hand…

bec8020

…le malformed dates Signed-off-by: v3DJG6GL <72495210+v3DJG6GL@users.noreply.github.com>

fix(contacts): add try-catch to rev getter for UI safety with malform…

101c461

…ed dates Signed-off-by: v3DJG6GL <72495210+v3DJG6GL@users.noreply.github.com>

fix(contacts): skip re-sort after fetchFullContact and improve REV no…

33cb607

…rmalization Signed-off-by: v3DJG6GL <72495210+v3DJG6GL@users.noreply.github.com>

fix(contacts): remove fake REV=now from constructor

8af0083

Signed-off-by: v3DJG6GL <72495210+v3DJG6GL@users.noreply.github.com>

fix(contacts): disable invalidREV check to prevent fake timestamps

9662a66

Signed-off-by: v3DJG6GL <72495210+v3DJG6GL@users.noreply.github.com>

fix(contacts): use virtua align:nearest to prevent scroll jumps

286ff1a

Signed-off-by: v3DJG6GL <72495210+v3DJG6GL@users.noreply.github.com>

fix(contacts): fix lint error

de9a85e

Signed-off-by: v3DJG6GL <72495210+v3DJG6GL@users.noreply.github.com>

refactor(contacts): move REV timestamp extraction onto Contact model

6110d9c

Signed-off-by: v3DJG6GL <72495210+v3DJG6GL@users.noreply.github.com>

refactor(contacts): normalize updateContact mutation payload to {cont…

ad01118

…act, skipSort?} Signed-off-by: v3DJG6GL <72495210+v3DJG6GL@users.noreply.github.com>

fix(contacts): remove now-unused invalidREV check

d076903

Signed-off-by: v3DJG6GL <72495210+v3DJG6GL@users.noreply.github.com>

docs(contacts): explain skipSort in fetchFullContact

1e5e15c

Signed-off-by: v3DJG6GL <72495210+v3DJG6GL@users.noreply.github.com>

v3DJG6GL force-pushed the fix/sort-by-last-modified-5158 branch from e72a0aa to 1e5e15c Compare April 20, 2026 19:00

hamza221 added bug Something isn't working 3. to review Waiting for reviews labels Apr 23, 2026

github-actions Bot added the feedback-requested label May 5, 2026

Merge remote-tracking branch 'upstream/main' into fix/sort-by-last-mo…

41706ad

…dified-5158

hamza221 reviewed Jul 7, 2026

View reviewed changes

Comment thread src/components/ContactsList.vue

Comment thread src/models/contact.js

v3DJG6GL requested a review from SebastianKrupinski as a code owner July 8, 2026 22:21

GVodyanov reviewed Jul 11, 2026

View reviewed changes

Comment thread src/models/contact.js Outdated

MiMoHo mentioned this pull request Jul 12, 2026

fix(contacts): do not let one broken contact blank the whole app #5564

Open

2 tasks

hamza221 added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Aug 7, 2026

Merge remote-tracking branch 'upstream/main' into fix/sort-by-last-mo…

7f6e01a

…dified-5158 # Conflicts: # src/components/ContactsList.vue # src/models/contact.js # src/services/checks/invalidREV.js # src/store/contacts.js

Merge branch 'nextcloud:main' into fix/sort-by-last-modified-5158

2fadacf

Navigation Menu

Uh oh!

fix: Sort by "last modified" (issue #5158) - #5265

fix: Sort by "last modified" (issue #5158)#5265
v3DJG6GL wants to merge 25 commits into
nextcloud:mainfrom
v3DJG6GL:fix/sort-by-last-modified-5158

v3DJG6GL commented Apr 20, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Apr 20, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 5, 2026

Uh oh!

v3DJG6GL commented Jul 4, 2026 •

edited

Loading

Uh oh!

hamza221 left a comment

Uh oh!

Uh oh!

Uh oh!

hamza221 commented Jul 7, 2026

Uh oh!

Uh oh!

hamza221 commented Aug 7, 2026

Uh oh!

v3DJG6GL commented Aug 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

v3DJG6GL commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

LLM Disclosure

Uh oh!

codecov Bot commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented May 5, 2026

Uh oh!

v3DJG6GL commented Jul 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hamza221 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

hamza221 commented Jul 7, 2026

Uh oh!

Uh oh!

hamza221 commented Aug 7, 2026

Uh oh!

v3DJG6GL commented Aug 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

v3DJG6GL commented Apr 20, 2026 •

edited

Loading

codecov Bot commented Apr 20, 2026 •

edited

Loading

v3DJG6GL commented Jul 4, 2026 •

edited

Loading