Skip to content

Add shareable comparison links - #2700

Open
hweihwang wants to merge 1 commit into
review/collectives-version-comparisonfrom
review/collectives-version-comparison-routing
Open

Add shareable comparison links#2700
hweihwang wants to merge 1 commit into
review/collectives-version-comparisonfrom
review/collectives-version-comparison-routing

Conversation

@hweihwang

@hweihwang hweihwang commented Aug 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Part 6 of the version-comparison work for #599: shareable comparison links that pin two exact revisions.

  • compareFrom / compareTo pin two revisions; the pair survives reload, Back, Forward, copy and page rename
  • Namespaced identities (current: / version:) with aliases for older links; validation rejects non-strings, path separators, control characters, over-long values, identical and half-pairs
  • A missing version stays in the selector with a Retry action, never silently replaced; one history entry per path; rename canonicalizes only the slug
  • CI now checks out the signed Text review branch, so the e2e suite follows the Text stack under review

Depends on: #2699 (base review/collectives-version-comparison). Final unit of the six.

Full story, screenshots and the test matrix live in the #599 implementation update: #599 (comment)

@hweihwang hweihwang mentioned this pull request Aug 14, 2026
Open
@hweihwang hweihwang mentioned this pull request Aug 14, 2026
Open
@hweihwang
hweihwang force-pushed the review/collectives-version-comparison-routing branch 2 times, most recently from a964840 to 2c826e0 Compare August 17, 2026 15:27
@benjaminfrueh
benjaminfrueh self-requested a review August 18, 2026 07:55
@hweihwang
hweihwang force-pushed the review/collectives-version-comparison-routing branch from 2c826e0 to 80fb7fe Compare September 1, 2026 21:10
@hweihwang
hweihwang marked this pull request as ready for review September 1, 2026 21:24
@hweihwang
hweihwang requested review from benjaminfrueh and removed request for max-nextcloud, mejo- and silverkszlo September 1, 2026 21:34
@hweihwang
hweihwang force-pushed the review/collectives-version-comparison-routing branch from 80fb7fe to 10d62ec Compare September 1, 2026 23:42
@hweihwang
feat(versions): add shareable comparison links
8b07a6a 
Assisted-by: OpenAI Codex:gpt-5.6-sol
Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
@hweihwang
hweihwang force-pushed the review/collectives-version-comparison-routing branch from 10d62ec to 8b07a6a Compare September 2, 2026 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjaminfrueh benjaminfrueh benjaminfrueh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hweihwang @benjaminfrueh